Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 9675002: dbus: fix base class of ErrorResponse (Closed)

Created:
8 years, 9 months ago by keybuk
Modified:
8 years, 9 months ago
Reviewers:
stevenjb, satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

dbus: fix base class of ErrorResponse dbus::ErrorResponse needs to be a subclass of dbus::Response otherwise you can't pass it to a dbus::ExportedObject::ResponseSender. BUG=none TEST=my code now compiles Change-Id: I1efba7c2cd9aaed937cac75133ab6b695aeac63b Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126053

Patch Set 1 #

Patch Set 2 : (lost in appengine fu) fix up the constructors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M dbus/message.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M dbus/message.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
keybuk
8 years, 9 months ago (2012-03-10 00:02:05 UTC) #1
satorux1
LGTM
8 years, 9 months ago (2012-03-10 00:09:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9675002/1
8 years, 9 months ago (2012-03-10 00:32:32 UTC) #3
commit-bot: I haz the power
Try job failure for 9675002-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-10 00:50:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9675002/3002
8 years, 9 months ago (2012-03-10 00:50:27 UTC) #5
commit-bot: I haz the power
Try job failure for 9675002-3002 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-10 03:29:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9675002/3002
8 years, 9 months ago (2012-03-10 19:55:15 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-11 01:12:01 UTC) #8
Change committed as 126053

Powered by Google App Engine
This is Rietveld 408576698