Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9669057: Use PasswordStoreDefault on Android (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Ramya
Visibility:
Public.

Description

Use PasswordStoreDefault on Android Fixes link errors in PasswordStoreFactory BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126759

Patch Set 1 #

Patch Set 2 : self-reivew #

Patch Set 3 : rebased #

Total comments: 1

Patch Set 4 : add more OS_ANDROID guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/browser/password_manager/password_store_factory.cc View 1 2 3 6 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yaron
8 years, 9 months ago (2012-03-12 18:06:15 UTC) #1
Elliot Glaysher
On 2012/03/12 18:06:15, Yaron wrote: Could you please wait until after https://chromiumcodereview.appspot.com/9665007/ lands? You'll conflict ...
8 years, 9 months ago (2012-03-12 20:04:00 UTC) #2
Yaron
This has been re-applied on your patch. ptal
8 years, 9 months ago (2012-03-14 13:27:52 UTC) #3
Elliot Glaysher
http://codereview.chromium.org/9669057/diff/4001/chrome/browser/password_manager/password_store_factory.cc File chrome/browser/password_manager/password_store_factory.cc (right): http://codereview.chromium.org/9669057/diff/4001/chrome/browser/password_manager/password_store_factory.cc#newcode72 chrome/browser/password_manager/password_store_factory.cc:72: #if !defined(OS_MACOSX) && !defined(OS_CHROMEOS) && defined(OS_POSIX) Do you need ...
8 years, 9 months ago (2012-03-14 17:19:54 UTC) #4
Yaron
Added more guards (to match chromeos). It wasn't strictly necessary as the function was only ...
8 years, 9 months ago (2012-03-14 17:56:35 UTC) #5
Elliot Glaysher
lgtm
8 years, 9 months ago (2012-03-14 19:37:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9669057/5003
8 years, 9 months ago (2012-03-14 19:43:57 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 22:10:35 UTC) #8
Change committed as 126759

Powered by Google App Engine
This is Rietveld 408576698