webkit/glue/webkitplatformsupport_impl.h - Issue 9669039: Provide access to process private and shared memory size from WebKit code

Side by Side Diff: webkit/glue/webkitplatformsupport_impl.h

Issue 9669039: Provide access to process private and shared memory size from WebKit code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Moved { on the previous line Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | webkit/glue/webkitplatformsupport_impl.cc » ('j') | webkit/glue/webkitplatformsupport_impl.cc » ('J')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WEBKIT_PLATFORM_SUPPORT_IMPL_H_	5 #ifndef WEBKIT_PLATFORM_SUPPORT_IMPL_H_

6 #define WEBKIT_PLATFORM_SUPPORT_IMPL_H_	6 #define WEBKIT_PLATFORM_SUPPORT_IMPL_H_

7	7

8 #include "base/compiler_specific.h"	8 #include "base/compiler_specific.h"

9 #include "base/platform_file.h"	9 #include "base/platform_file.h"

10 #include "base/threading/thread_local_storage.h"	10 #include "base/threading/thread_local_storage.h"

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 virtual long databaseGetFileAttributes(	53 virtual long databaseGetFileAttributes(

54 const WebKit::WebString& vfs_file_name);	54 const WebKit::WebString& vfs_file_name);

55 virtual long long databaseGetFileSize(const WebKit::WebString& vfs_file_name);	55 virtual long long databaseGetFileSize(const WebKit::WebString& vfs_file_name);

56 virtual long long databaseGetSpaceAvailableForOrigin(	56 virtual long long databaseGetSpaceAvailableForOrigin(

57 const WebKit::WebString& origin_identifier);	57 const WebKit::WebString& origin_identifier);

58 virtual WebKit::WebString signedPublicKeyAndChallengeString(	58 virtual WebKit::WebString signedPublicKeyAndChallengeString(

59 unsigned key_size_index, const WebKit::WebString& challenge,	59 unsigned key_size_index, const WebKit::WebString& challenge,

60 const WebKit::WebURL& url);	60 const WebKit::WebURL& url);

61 virtual size_t memoryUsageMB();	61 virtual size_t memoryUsageMB();

62 virtual size_t actualMemoryUsageMB();	62 virtual size_t actualMemoryUsageMB();

	63 virtual bool getProcessMemorySize(size_t* private_bytes,

	64 size_t* shared_bytes);
	tony 2012/05/29 18:11:18 Some comments about the upstream change: Should th Some comments about the upstream change: Should this method have been added next to the memory functions in Source/Platform/chromium/public/Platform.h? Also, webkit style doesn't normally prefix methods with 'get'. Finally, I would have included the units in the method name, e.g., processMemorySizesInBytes. yurys 2012/05/30 08:06:27 This patch was created when Source/Platform/chrom Show quoted text On 2012/05/29 18:11:18, tony wrote: > Some comments about the upstream change: > Should this method have been added next to the memory functions in > Source/Platform/chromium/public/Platform.h? This patch was created when Source/Platform/chromium/public/Platform.h didn't exist (2.5 months ago). Show quoted text > Also, webkit style doesn't normally prefix methods with 'get'. > Finally, I would have included the units in the > method name, e.g., processMemorySizesInBytes. Some methods returning results in arguments have 'get' prefix and I followed that naming style. I've sent WebKit change addressing your comments: https://bugs.webkit.org/show_bug.cgi?id=87830
63 virtual WebKit::WebURLLoader* createURLLoader();	65 virtual WebKit::WebURLLoader* createURLLoader();

64 virtual WebKit::WebSocketStreamHandle* createSocketStreamHandle();	66 virtual WebKit::WebSocketStreamHandle* createSocketStreamHandle();

65 virtual WebKit::WebString userAgent(const WebKit::WebURL& url);	67 virtual WebKit::WebString userAgent(const WebKit::WebURL& url);

66 virtual void getPluginList(bool refresh, WebKit::WebPluginListBuilder*);	68 virtual void getPluginList(bool refresh, WebKit::WebPluginListBuilder*);

67 virtual void decrementStatsCounter(const char* name);	69 virtual void decrementStatsCounter(const char* name);

68 virtual void incrementStatsCounter(const char* name);	70 virtual void incrementStatsCounter(const char* name);

69 virtual void histogramCustomCounts(	71 virtual void histogramCustomCounts(

70 const char* name, int sample, int min, int max, int bucket_count);	72 const char* name, int sample, int min, int max, int bucket_count);

71 virtual void histogramEnumeration(	73 virtual void histogramEnumeration(

72 const char* name, int sample, int boundary_value);	74 const char* name, int sample, int boundary_value);

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
153 void (*shared_timer_func_)();	155 void (*shared_timer_func_)();

154 double shared_timer_fire_time_;	156 double shared_timer_fire_time_;

155 int shared_timer_suspended_; // counter	157 int shared_timer_suspended_; // counter

156 WebThemeEngineImpl theme_engine_;	158 WebThemeEngineImpl theme_engine_;

157 base::ThreadLocalStorage::Slot current_thread_slot_;	159 base::ThreadLocalStorage::Slot current_thread_slot_;

158 };	160 };

159	161

160 } // namespace webkit_glue	162 } // namespace webkit_glue

161	163

162 #endif // WEBKIT_PLATFORM_SUPPORT_IMPL_H_	164 #endif // WEBKIT_PLATFORM_SUPPORT_IMPL_H_

OLD	NEW