fixed about:flags by switching onclick to onchange for select element

fixed about:flags by switching onclick to onchange for select element

BUG=107798
TEST=multi-state works on mac in chrome:flags


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126342

[Stephen Searles, 2012-03-11 09:42:52]

On Mac, click events don't get sent for select elements, but change events do.
This patch implements the expected behavior.

[Dan Beam, 2012-03-12 08:45:07]

this seems to look like the right fix at first glance (trying on Mac OS), but I
need to run the same code on Linux/Win tomorrow to check it works the same
everywhere.  additionally, there could be a webkit bug at play here if the
select is getting different events per platform (or maybe just doesn't get
onclicks anywhere?)

[Stephen Searles, 2012-03-12 14:41:04]

There most certainly is a webkit bug, and there's talk about it here:
https://code.google.com/p/chromium/issues/detail?id=36518&can=5&colspec=ID%20...

However, the event bound here should be onchange instead of onclick regardless,
because it's really only when that select changes that we're interested in
responding.

[Dan Beam, 2012-03-12 19:11:38]

lgtm (tried on other platforms, seems fine)

[Dan Beam, 2012-03-12 19:13:24]

Stephen: add yourself to src/AUTHORS and click commit when you have

[commit-bot: I haz the power, 2012-03-13 04:27:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stephen.searles@gmail.com/9669036/3002

[commit-bot: I haz the power, 2012-03-13 05:48:27]

Change committed as 126342