Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 9668039: Move active_downloads_ui.* to chrome/browser/ui/webui/chromeos (Closed)

Created:
8 years, 9 months ago by asanka
Modified:
8 years, 9 months ago
Reviewers:
achuithb, sky, Evan Stade
CC:
chromium-reviews, achuith+watch_chromium.org, Randy Smith (Not in Mondays), rdsmith+dwatch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Move active_downloads_ui.* to chrome/browser/ui/webui/chromeos BUG=none TEST=unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126638

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 2

Patch Set 3 : Sort headers #

Patch Set 4 : Rebased #

Patch Set 5 : Rebase again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -458 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_close_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/webui/active_downloads_ui.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/webui/active_downloads_ui.cc View 1 chunk +0 lines, -400 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/chromeos/active_downloads_ui.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/chromeos/active_downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
asanka
8 years, 9 months ago (2012-03-10 01:04:05 UTC) #1
achuithb
Please also run this against the linux_chromeos_gtk trybot. LGTM assuming you get a green run ...
8 years, 9 months ago (2012-03-10 03:55:57 UTC) #2
asanka
Thanks! Will do a CrOS GTK try run. http://codereview.chromium.org/9668039/diff/4001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc File chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc (right): http://codereview.chromium.org/9668039/diff/4001/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc#newcode70 chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc:70: #include ...
8 years, 9 months ago (2012-03-10 05:10:30 UTC) #3
asanka
+sky for chrome/browser/ui/OWNERS active_downloads is only used on ChromeOS. This CL is to move it ...
8 years, 9 months ago (2012-03-12 16:15:58 UTC) #4
sky
I'm not a webui owner, but the other chrome/browser/ui changes LGTM
8 years, 9 months ago (2012-03-12 17:11:23 UTC) #5
asanka
On 2012/03/12 17:11:23, sky wrote: > I'm not a webui owner, but the other chrome/browser/ui ...
8 years, 9 months ago (2012-03-12 17:16:15 UTC) #6
Evan Stade
lgtm
8 years, 9 months ago (2012-03-12 20:16:30 UTC) #7
asanka
On 2012/03/12 20:16:30, Evan Stade wrote: > lgtm Thanks!
8 years, 9 months ago (2012-03-12 21:06:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9668039/4012
8 years, 9 months ago (2012-03-12 21:08:19 UTC) #9
commit-bot: I haz the power
Try job failure for 9668039-4012 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-12 21:51:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9668039/4012
8 years, 9 months ago (2012-03-12 23:08:28 UTC) #11
commit-bot: I haz the power
Try job failure for 9668039-4012 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-12 23:27:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9668039/4012
8 years, 9 months ago (2012-03-13 14:15:30 UTC) #13
commit-bot: I haz the power
Try job failure for 9668039-4012 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 16:54:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9668039/4012
8 years, 9 months ago (2012-03-13 18:13:51 UTC) #15
commit-bot: I haz the power
Try job failure for 9668039-4012 (retry) on win_rel for step "ui_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 20:46:52 UTC) #16
achuithb
On 2012/03/13 20:46:52, I haz the power (commit-bot) wrote: > Try job failure for 9668039-4012 ...
8 years, 9 months ago (2012-03-13 21:00:55 UTC) #17
asanka
8 years, 9 months ago (2012-03-13 21:07:46 UTC) #18
On 2012/03/13 21:00:55, achuith.bhandarkar wrote:
> On 2012/03/13 20:46:52, I haz the power (commit-bot) wrote:
> > Try job failure for 9668039-4012 (retry) on win_rel for step "ui_tests".
> > It's a second try, previously, steps "ui_tests, installer_util_unittests"
> > failed.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
> 
> Wow! I think it's time for gcl commit

Yup. I'll do so later in the evening when I have time to babysit the commit.

Powered by Google App Engine
This is Rietveld 408576698