webkit/plugins/plugin_constants.h - Issue 9668031: Implement BrowserPluginPlaceholder.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/plugins/plugin_constants.h

Issue 9668031: Implement BrowserPluginPlaceholder. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Updated according to comments by jam Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | webkit/plugins/plugin_constants.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WEBKIT_PLUGINS_PLUGIN_CONSTANTS_H_	5 #ifndef WEBKIT_PLUGINS_PLUGIN_CONSTANTS_H_

6 #define WEBKIT_PLUGINS_PLUGIN_CONSTANTS_H_	6 #define WEBKIT_PLUGINS_PLUGIN_CONSTANTS_H_

7	7

8 #include "webkit/plugins/webkit_plugins_export.h"	8 #include "webkit/plugins/webkit_plugins_export.h"

9	9

	10 WEBKIT_PLUGINS_EXPORT extern const char kBrowserPluginName[];
	jam 2012/03/13 17:14:24 why are these in webkit/plugins/plugin_constants.h why are these in webkit/plugins/plugin_constants.h? that file is for constants that the webkit module needs to know about, which isn't the case here.
	11 WEBKIT_PLUGINS_EXPORT extern const char kBrowserPluginMimeType[];

	12 WEBKIT_PLUGINS_EXPORT extern const char kBrowserPluginPath[];

	13 WEBKIT_PLUGINS_EXPORT extern const char kBrowserPluginDescription[];

10 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginName[];	14 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginName[];

11 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSwfMimeType[];	15 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSwfMimeType[];

12 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSwfExtension[];	16 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSwfExtension[];

13 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSwfDescription[];	17 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSwfDescription[];

14 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSplMimeType[];	18 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSplMimeType[];

15 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSplExtension[];	19 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSplExtension[];

16 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSplDescription[];	20 WEBKIT_PLUGINS_EXPORT extern const char kFlashPluginSplDescription[];

17	21

18 #endif // WEBKIT_PLUGINS_PLUGIN_CONSTANTS_H_	22 #endif // WEBKIT_PLUGINS_PLUGIN_CONSTANTS_H_

OLD	NEW