Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 9668018: dbus: remove service name from ExportedObject (Closed)

Created:
8 years, 9 months ago by keybuk
Modified:
8 years, 9 months ago
Reviewers:
stevenjb, satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

dbus: remove service name from ExportedObject Well-known names in D-Bus are merely aliases to unique connection ids maintained by the bus, they have no purpose in qualifying object paths or interfaces and it's perfectly legimiate for a client to make requests to the unique connection id (e.g. in response to a signal, which does not reference the well-known name of the origin connection). Remove the service_name member from dbus::ExportedObject, from its constructor and from dbus::Bus::GetExportedObject and require code to call dbus::Bus::RequestOwnership if a well-known name is desired. This requires making that function callable from the origin thread with a callback for the return value. BUG=chromium-os:27101 TEST=dbus_unittests Change-Id: Ib91de8b68ad9c3b432e224a2c715f0c2ca1af463 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125970

Patch Set 1 #

Patch Set 2 : add missing #include #

Patch Set 3 : fix mock #

Patch Set 4 : pay more attention when fixing mock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -41 lines) Patch
M chrome/browser/chromeos/dbus/cros_dbus_service.cc View 1 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/cros_dbus_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/dbus/proxy_resolution_service_provider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M dbus/bus.h View 6 chunks +31 lines, -8 lines 0 comments Download
M dbus/bus.cc View 2 chunks +38 lines, -7 lines 0 comments Download
M dbus/bus_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M dbus/exported_object.h View 2 chunks +1 line, -4 lines 0 comments Download
M dbus/exported_object.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M dbus/mock_bus.h View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M dbus/mock_exported_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M dbus/mock_exported_object.cc View 1 chunk +1 line, -2 lines 0 comments Download
M dbus/test_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M dbus/test_service.cc View 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
keybuk
8 years, 9 months ago (2012-03-09 19:24:06 UTC) #1
satorux1
LGTM
8 years, 9 months ago (2012-03-09 21:44:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/9668018/1017
8 years, 9 months ago (2012-03-09 22:40:34 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-10 01:12:54 UTC) #4
Change committed as 125970

Powered by Google App Engine
This is Rietveld 408576698