Move proxy handling into network details.

chrome/browser/resources/options2/chromeos/internet_detail.html

 <div id="detailsInternetPage" class="page" hidden>
   <div id="internet-details-content-area" class="content-area">
     <!-- Network header -->
     <div>
       <div id="network-details-header">
         <div id="network-details-title"></div>
         <div id="network-details-subtitle">
           <span id="network-details-subtitle-status"></span>
           <span id="network-details-subtitle-separator"> - </span> 
           <span id="network-details-subtitle-type"></span>
@@ skipping 38 matching lines @@
       </span>
       <span id="internetNavTab" class="tab" tab-contents="internetTab">
         <span class="tab-label" i18n-content="networkTabLabel"></span>
         <span class="active-tab-label" i18n-content="networkTabLabel"></span>
       </span>
       <span id="security-nav-tab" class="tab cellular-details gsm-only"
           tab-contents="security-tab">
         <span class="tab-label" i18n-content="securityTabLabel"></span>
         <span class="active-tab-label" i18n-content="securityTabLabel"></span>
       </span>
+      <span id="internet-proxy-nav-tab" class="tab proxy-details"
+          tab-contents="network-proxy-tab">
+        <span class="tab-label" i18n-content="proxyTabLabel"></span>
+        <span class="active-tab-label" i18n-content="proxyTabLabel">
+        </span>

[csilv, 2012/03/09 22:30:14]

nit: it looks like line 63 could fit at the end of 62.

[kevers, 2012/03/12 13:57:13]

Done.

+      </span>
     </div>
     <div id="wifiNetworkTab" class="subpages-tab-contents wifi-details">
       <section>
         <table class="ssid-table">
           <tr>
             <td class="option-name" i18n-content="inetSsid"></td>
             <td id="inetSsid" class="option-value"></td>
           </tr>
         </table>
       </section>
@@ skipping 268 matching lines @@
               <span i18n-content="useStaticIP"></span>
             </label>
             <span class="controlled-setting-indicator" data="ipconfigStatic"
                 for="ipTypeStatic"></span>
           </div>
           <div id="ipConfigManagement" class="settings-list">
             <list id="ipConfigList"></list>
           </div>
         </div>
       </section>
-      <section id="change-proxy-section">
-        <div>
-          <button id="change-proxy-button" i18n-content="changeProxyButton">
-          </button>
-        </div>
-      </section>
     </div>
     <div id="security-tab"
          class="subpages-tab-contents cellular-details gsm-only">
       <div id="cellular-security-options">
         <section>
           <div id="sim-pin-lock" class="checkbox">
             <label>
               <input id="sim-card-lock-enabled" type="checkbox">
               <span i18n-content="lockSimCard"></span>
             </label>
             <span class="controlled-setting-indicator" data="simCardLockEnabled"
                 for="sim-card-lock-enabled"></span>
           </div>
         </section>
         <section>
           <div id="change-pin-area">
             <button id="change-pin" i18n-content="changePinButton"></button>
             <span class="controlled-setting-indicator" data="simCardLockEnabled"
                 for="change-pin"></span>
           </div>
         </section>
       </div>
     </div>
+    <div id="network-proxy-tab" class="subpages-tab-contents">
+      <section>
+        <div id="info-banner" hidden>
+          <span id="banner-icon" class="managed-prefs-icon"></span>
+          <span id="banner-text" class="managed-prefs-text"></span>
+        </div>
+        <div class="radio">
+          <label>
+            <input id="directProxy" type="radio" name="proxytype" value="1"
+                pref="cros.session.proxy.type">
+            <span i18n-content="proxyDirectInternetConnection"></span>
+          </label>
+        </div>
+        <div class="radio">
+          <label>
+            <input id="manualProxy" type="radio" name="proxytype" value="2"
+                pref="cros.session.proxy.type">
+            <span i18n-content="proxyManual"></span>
+          </label>
+        </div>
+        <div class="checkbox">
+          <label>
+            <input id="proxyAllProtocols" type="checkbox"
+                pref="cros.session.proxy.single">
+            <span i18n-content="sameProxyProtocols"></span>
+          </label>
+        </div>
+        <div id="singleProxy">
+          <table>
+            <tr>
+              <td>
+                <span i18n-content="httpProxy"></span>
+                <input id="proxyHostSingleName" type="text" size="25"
+                    pref="cros.session.proxy.singlehttp" disabled>
+              </td>
+              <td>
+                <span i18n-content="proxyPort"></span>
+                <input id="proxyHostSinglePort" type="text" data-type="number"
+                    size="4" pref="cros.session.proxy.singlehttpport" disabled>
+              </td>
+            </tr>
+          </table>
+        </div>
+        <div id="multiProxy">
+          <table>
+            <tr>
+              <td>
+                <span i18n-content="httpProxy"></span>
+              </td>
+              <td>
+                <input id="proxyHostName" type="text" size="25"
+                    pref="cros.session.proxy.httpurl" disabled>
+              </td>
+              <td>
+                <span i18n-content="proxyPort"></span>
+              </td>
+              <td>
+                <input id="proxyHostPort" type="text" data-type="number" size="4"

[csilv, 2012/03/09 22:30:14]

nit, wrap to 80 cols, here and line 449

[kevers, 2012/03/12 13:57:13]

Done.

+                    pref="cros.session.proxy.httpport" disabled>
+              </td>
+            </tr>
+            <tr>
+              <td>
+                <span i18n-content="secureHttpProxy"></span>
+              </td>
+              <td>
+                <input id="secureProxyHostName" type="text" size="25"
+                    pref="cros.session.proxy.httpsurl" disabled>
+              </td>
+              <td>
+                <span i18n-content="proxyPort"></span>
+              </td>
+              <td>
+                <input id="secureProxyPort" type="text" data-type="number" size="4"
+                    pref="cros.session.proxy.httpsport" disabled>
+              </td>
+            </tr>
+            <tr>
+              <td>
+                <span i18n-content="ftpProxy"></span>
+              </td>
+              <td>
+                <input id="ftpProxy" type="text" size="25"
+                    pref="cros.session.proxy.ftpurl" disabled>
+              </td>
+              <td>
+                <span i18n-content="proxyPort"></span>
+                </td>
+              <td>
+                <input id="ftpProxyPort" type="text" data-type="number" size="4"
+                    pref="cros.session.proxy.ftpport" disabled>
+              </td>
+            </tr>
+            <tr>
+              <td>
+                <span i18n-content="socksHost"></span>
+              </td>
+              <td>
+                <input id="socksHost" type="text" size="25"
+                    pref="cros.session.proxy.socks" disabled>
+              </td>
+              <td>
+                <span i18n-content="proxyPort"></span>
+              </td>
+              <td>
+                <input id="socksPort" type="text" data-type="number" size="4"
+                    pref="cros.session.proxy.socksport" disabled>
+              </td>
+            </tr>
+          </table>
+        </div>
+        <div class="radio">
+          <label>
+            <input id="autoProxy" type="radio" name="proxytype" value="3"
+                pref="cros.session.proxy.type">
+            <span i18n-content="proxyAutomatic"></span>
+          </label>
+        </div>
+        <div>
+          <label>
+            <div i18n-content="proxyConfigUrl"></div>
+            <input id="proxyConfig" type="url" size="50"
+                pref="cros.session.proxy.pacurl">
+          </label>
+        </div>
+        <div id="advancedConfig">
+          <h3 i18n-content="advanced_proxy_config"></h3>
+          <div class="option vbox flex">
+            <div i18n-content="proxyBypass"></div>
+            <list id="ignoredHostList"></list>
+            <input id="newHost" type="url" size="30">
+            <button id="addHost" i18n-content="addHost"></button>
+            <button id="removeHost" i18n-content="removeHost"></button>
+          </div>
+        </div>
+      </section>
+    </div>
   </div>
   <div class="action-area">
     <div class="button-strip">
       <!-- TODO(dbeam): Clarify style guide regarding tag wrap. -->
       <button id="detailsInternetDismiss" i18n-content="detailsInternetDismiss">
       </button>
       <button id="detailsInternetLogin" i18n-content="connect_button"></button>
       <button id="detailsInternetDisconnect" i18n-content="disconnect_button">
       </button>
       <button id="activateDetails" i18n-content="activate_button"></button>
       <button id="buyplanDetails" i18n-content="buyplan_button"></button>
       <button id="viewAccountDetails" i18n-content="view_account_button">
       </button>
     </div>
   </div>
 </div>

[csilv, 2012/03/09 22:30:14]

Consider adding a TODO for a style cleanup.. like lowercase id tags.

[kevers, 2012/03/12 13:57:13]

Done.