Use FileEntry.copyTo() and FileEntry.moveTo() on GData file system.

Use FileEntry.copyTo() and FileEntry.moveTo() on GData file system.

This CL changes the FileCopyManager to use FileEntry.copyTo() /
FileEntry.moveTo() to copy / move files within the GData file system,
which calls GDataFileSystem::Copy() / GDataFileSystem::Move() under the
hood.

BUG=chromium-os:26962
TEST=Manually tested copy, move, and rename operations on GData mount point.
(Copying of regular files is not implemented)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126178

[Ben Chan, 2012-03-12 03:03:52]

Related CL: http://chromiumcodereview.appspot.com/9662041/

http://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resources...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resources...
chrome/browser/resources/file_manager/js/file_manager.js:1282: if (event.reason
== 'BEGIN') {
This change is to prevent 'unknown event: BEGIN' from being printed to the
console.

[dgozman, 2012-03-12 09:46:03]

LGTM

http://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resources...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

http://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resources...
chrome/browser/resources/file_manager/js/file_copy_manager.js:476:
sourceEntry.moveTo(targetDirEntry, targetRelativePath,
Can we have such copyTo/moveTo methods for all entries? It would be much cleaner
for clients.

http://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resources...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resources...
chrome/browser/resources/file_manager/js/file_manager.js:1282: if (event.reason
== 'BEGIN') {
On 2012/03/12 03:03:53, Ben Chan wrote:
> This change is to prevent 'unknown event: BEGIN' from being printed to the
> console.

Thank you for the fix.

[Ben Chan, 2012-03-12 14:58:47]

https://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://chromiumcodereview.appspot.com/9667040/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_copy_manager.js:476:
sourceEntry.moveTo(targetDirEntry, targetRelativePath,
On 2012/03/12 09:46:03, dgozman wrote:
> Can we have such copyTo/moveTo methods for all entries? It would be much
cleaner
> for clients.

It's possible to use copyTo/moveTo for native filesystems. But I guess the
existing code uses other approach in order to cross origins and show progress of
copying. Is that correct, @rginda?    We may be able to optimize for certain
cases using copyTo/moveTo.

[commit-bot: I haz the power, 2012-03-12 17:21:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benchan@chromium.org/9667040/1

[commit-bot: I haz the power, 2012-03-12 19:06:23]

Change committed as 126178