Issue 9667018: Make FFmpegVideoDecoder defer a flush until the pending read completes.

Issue 9667018: Make FFmpegVideoDecoder defer a flush until the pending read completes. (Closed)

Created:
8 years, 9 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 9 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make FFmpegVideoDecoder defer a flush until the pending read completes. BUG=109875 TEST=FFmpegVideoDecoderTest.Flush_DuringPendingRead Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126183

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address CR comment. #

Patch Set 3 : Remove flakiness comments. #

Patch Set 4 : Fix rebase build buster #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -5 lines)			Patch
M	media/filters/ffmpeg_video_decoder.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View	1 2	2 chunks	+20 lines, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download
M	media/filters/pipeline_integration_test.cc	View	1 2	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM http://codereview.chromium.org/9667018/diff/1/media/filters/ffmpeg_video_decoder_unittest.cc File media/filters/ffmpeg_video_decoder_unittest.cc (right): http://codereview.chromium.org/9667018/diff/1/media/filters/ffmpeg_video_decoder_unittest.cc#newcode473 media/filters/ffmpeg_video_decoder_unittest.cc:473: remove extra line

8 years, 9 months ago (2012-03-10 01:42:32 UTC) #2

acolwell GONE FROM CHROMIUM

http://codereview.chromium.org/9667018/diff/1/media/filters/ffmpeg_video_decoder_unittest.cc File media/filters/ffmpeg_video_decoder_unittest.cc (right): http://codereview.chromium.org/9667018/diff/1/media/filters/ffmpeg_video_decoder_unittest.cc#newcode473 media/filters/ffmpeg_video_decoder_unittest.cc:473: On 2012/03/10 01:42:32, scherkus wrote: > remove extra line ...

8 years, 9 months ago (2012-03-10 02:00:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/9667018/5002

8 years, 9 months ago (2012-03-12 16:50:45 UTC) #4

Change committed as 126183

Expand Messages | Collapse Messages