Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 9667012: Fix --single-process mode issues with GpuChannelHostFactory (Closed)

Created:
8 years, 9 months ago by piman
Modified:
8 years, 9 months ago
Reviewers:
jam, apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, erikwright (departed)
Visibility:
Public.

Description

Fix --single-process mode issues with GpuChannelHostFactory GpuChannelHostFactory itself is no longer a singleton, we pass it explicitly to WebGraphicsContext3DCommandBufferImpl. That prevents RenderThreadImpl and BrowserGpuChannelHostFactory from stomping on each other in --single-process mode BUG=117594 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 2 chunks +1 line, -10 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/common/webkitplatformsupport_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/common/webkitplatformsupport_impl.cc View 1 chunk +10 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
It's a fairly trivial refactoring. apatrick: please review jam: OWNERS
8 years, 9 months ago (2012-03-09 22:22:45 UTC) #1
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-09 22:57:39 UTC) #2
jam
lgtm
8 years, 9 months ago (2012-03-10 00:43:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9667012/1
8 years, 9 months ago (2012-03-10 00:56:18 UTC) #4
commit-bot: I haz the power
Try job failure for 9667012-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 9 months ago (2012-03-10 04:55:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9667012/1
8 years, 9 months ago (2012-03-12 17:10:44 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 19:51:24 UTC) #7
Change committed as 126194

Powered by Google App Engine
This is Rietveld 408576698