chrome/browser/ui/startup/startup_browser_creator_impl.cc - Issue 9667009: CommandLine Page Cycler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 9667009: CommandLine Page Cycler (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Replaced now-private BrowserList::GetLastActive() Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc

diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

index 5d94e6b447263e40df67fe06075d67b9620d6de7..05575e855aa71c560620201f17234945f3965b6e 100644

--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc

+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc

@@ -351,7 +351,9 @@ bool StartupBrowserCreatorImpl::Launch(Profile* profile,

if (record_mode && chrome::kRecordModeEnabled)

base::EventRecorder::current()->StartRecording(script_path);

- if (playback_mode)

+ // Do not enter Playback mode if PageCycler is running; Playback mode does

+ // not work correctly.

+ if (playback_mode && !command_line_.HasSwitch(switches::kVisitURLs))

base::EventRecorder::current()->StartPlayback(script_path);

}