Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: gcl.py

Issue 9666062: Fix the warning in gcl to tell people they can use the commit queue. (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """\ 6 """\
7 Wrapper script around Rietveld's upload.py that simplifies working with groups 7 Wrapper script around Rietveld's upload.py that simplifies working with groups
8 of files. 8 of files.
9 """ 9 """
10 10
(...skipping 1115 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 filename = line[7:] 1126 filename = line[7:]
1127 new_cl_files.append((status, filename)) 1127 new_cl_files.append((status, filename))
1128 1128
1129 if (not len(change_info.GetFiles()) and not change_info.issue and 1129 if (not len(change_info.GetFiles()) and not change_info.issue and
1130 not len(new_description) and not new_cl_files): 1130 not len(new_description) and not new_cl_files):
1131 ErrorExit("Empty changelist not saved") 1131 ErrorExit("Empty changelist not saved")
1132 1132
1133 change_info._files = new_cl_files 1133 change_info._files = new_cl_files
1134 change_info.Save() 1134 change_info.Save()
1135 if svn_info.get('URL', '').startswith('http:'): 1135 if svn_info.get('URL', '').startswith('http:'):
1136 Warn("WARNING: Creating CL in a read-only checkout. You will not be " 1136 Warn("WARNING: Creating CL in a read-only checkout. You will need to "
1137 "able to commit it!") 1137 "commit using a commit queue!")
1138 1138
1139 print change_info.name + " changelist saved." 1139 print change_info.name + " changelist saved."
1140 if change_info.MissingTests(): 1140 if change_info.MissingTests():
1141 Warn("WARNING: " + MISSING_TEST_MSG) 1141 Warn("WARNING: " + MISSING_TEST_MSG)
1142 1142
1143 # Update the Rietveld issue. 1143 # Update the Rietveld issue.
1144 if change_info.issue and change_info.NeedsUpload(): 1144 if change_info.issue and change_info.NeedsUpload():
1145 change_info.UpdateRietveldDescription() 1145 change_info.UpdateRietveldDescription()
1146 change_info.needs_upload = False 1146 change_info.needs_upload = False
1147 change_info.Save() 1147 change_info.Save()
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
1445 raise 1445 raise
1446 print >> sys.stderr, ( 1446 print >> sys.stderr, (
1447 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith ' 1447 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
1448 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)) 1448 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
1449 return 1 1449 return 1
1450 1450
1451 1451
1452 if __name__ == "__main__": 1452 if __name__ == "__main__":
1453 fix_encoding.fix_encoding() 1453 fix_encoding.fix_encoding()
1454 sys.exit(main(sys.argv[1:])) 1454 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698