Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9666056: valgrind.sh vs gdb: keep the registers in gdb in sync with the code. (Closed)

Created:
8 years, 9 months ago by Timur Iskhodzhanov
Modified:
8 years, 9 months ago
CC:
chromium-reviews, glider+watch_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

valgrind.sh vs gdb: keep the registers in gdb in sync with the code. This might come at a performance price but I don't think this is important for valgrind.sh (please note the tests on the bots are started using a different runner) BUG=113513 TEST=http://code.google.com/p/chromium/issues/detail?id=113513#c8 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/valgrind/valgrind.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Timur Iskhodzhanov
Hi Alexey, Evgeniy, Can you please try locally for sanity checks and review this small ...
8 years, 9 months ago (2012-03-12 14:55:43 UTC) #1
alexeypa (please no reviews)
LGTM
8 years, 9 months ago (2012-03-12 18:51:52 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-13 09:32:29 UTC) #3
Timur Iskhodzhanov
Alexander, Can you please review to please the CQ? Thanks, Timur
8 years, 9 months ago (2012-03-13 10:05:11 UTC) #4
Timur Iskhodzhanov
ping
8 years, 9 months ago (2012-03-15 08:28:56 UTC) #5
Alexander Potapenko
LGTM
8 years, 9 months ago (2012-03-15 08:56:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/9666056/1
8 years, 9 months ago (2012-03-15 08:57:02 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 10:34:40 UTC) #8
Change committed as 126883

Powered by Google App Engine
This is Rietveld 408576698