Change the idle logout dialog over to use views.

chrome/browser/chromeos/ui/idle_logout_dialog.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_UI_IDLE_LOGOUT_DIALOG_H_
+#define CHROME_BROWSER_CHROMEOS_UI_IDLE_LOGOUT_DIALOG_H_
+#pragma once
+
+#include "base/memory/scoped_ptr.h"

[tfarina, 2012/03/14 16:45:47]

nit: remove, unused here.

[rkc, 2012/03/14 22:35:32]

Done.

+#include "base/string16.h"

[tfarina, 2012/03/14 16:45:47]

nit: this comes from from dialog_delegate.h below, so you can remove this.

[rkc, 2012/03/14 22:35:32]

Done.

+#include "base/timer.h"
+#include "ui/views/controls/label.h"

[tfarina, 2012/03/14 16:45:47]

nit: just forward declare this instead.

[rkc, 2012/03/14 22:35:32]

Done.

+#include "ui/views/window/dialog_delegate.h"
+
+namespace base {
+class TimeDelta;
+}
+
+// A class to show the logout on idle dialog if the machine is in retail mode.
+class IdleLogoutDialog : public views::DialogDelegateView {

[tfarina, 2012/03/14 16:45:47]

nit: As many other views dialog, I'd name this as IdleLogoutDialogView and
rename the file_name as well.

[rkc, 2012/03/14 22:35:32]

Done.

+ public:
+  static void ShowIdleLogoutDialog();

[tfarina, 2012/03/14 16:45:47]

nit: This names is redundant. I think it's better just Show() and Close().

Instead of having:

IdleLogoutDialog::ShowIdleLogoutDialog();

Have an:

IdleLogoutDialog::Show();

Same for CloseIdleLogoutDialog();

[rkc, 2012/03/14 22:35:32]

Show/CloseDialog seem more appropriate; renaming to those.
Done.

+  static void CloseIdleLogoutDialog();
+
+  // views::DialogDelegateView:
+  virtual int GetDialogButtons() const OVERRIDE;
+  virtual ui::ModalType GetModalType() const OVERRIDE;
+  virtual string16 GetWindowTitle() const  OVERRIDE;
+  virtual views::View* GetContentsView()  OVERRIDE;
+  virtual void DeleteDelegate() OVERRIDE;
+
+  // views::View
+  virtual void Layout() OVERRIDE;
+  virtual gfx::Size GetPreferredSize() OVERRIDE;
+
+ private:
+  IdleLogoutDialog();
+
+  // Calls init after checking if the class is still alive.
+  static void CallInit(IdleLogoutDialog** dialog);
+  // Adds the labels and adds them to the layout.
+  void Init();
+
+  void Show();
+  void Close();
+
+  void UpdateCountdownTimer();
+
+  // Indicate that this instance has been 'closed' and should not be used.
+  void set_closed() { *instance_holder_ = NULL; }
+  // If our instance holder holds NULL, means we've been closed already.
+  bool is_closed() { return NULL == *instance_holder_; }

[tfarina, 2012/03/14 16:45:47]

nit: bool is_closed() const { ... };

[rkc, 2012/03/14 22:35:32]

Done.

+
+  views::Label* restart_label_;
+  views::Label* warning_label_;
+
+  // Time at which the countdown is over and we should close the dialog.
+  base::Time countdown_end_time_;
+
+  base::RepeatingTimer<IdleLogoutDialog> timer_;
+
+  // Holds a pointer to our instance; if we are closed, we set this to hold
+  // a NULL value, indicating that our instance is been 'closed' and should
+  // not be used further. The delete will happen async to the closing.
+  IdleLogoutDialog** instance_holder_;
+
+  DISALLOW_COPY_AND_ASSIGN(IdleLogoutDialog);
+};
+
+#endif  // CHROME_BROWSER_CHROMEOS_UI_IDLE_LOGOUT_DIALOG_H_