Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 9665017: PluginLoader loads plugins again after last load completes (Closed)

Created:
8 years, 9 months ago by Alpha Left Google
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

PluginLoader loads plugins again after last load completes If the list of plugins has updated before PluginLoader gets a request to load plugins it occasionally fails to load the entire list. This happens when PluginLoader is serving the last plugin load request. To make sure PluginLoader is up-to-date with the latest plugin list all plugin load requests are served. BUG=117561 TEST=content_unittests --gtest_filter=PluginLoader* R=rsesek Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126250

Patch Set 1 #

Patch Set 2 : remove logs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M content/browser/plugin_loader_posix.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 chunk +14 lines, -6 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Alpha Left Google
8 years, 9 months ago (2012-03-09 21:51:33 UTC) #1
James Hawkins
I'm not sure I'm the right person to review this.
8 years, 9 months ago (2012-03-09 21:53:21 UTC) #2
Alpha Left Google
Add jam@ as reviewer.
8 years, 9 months ago (2012-03-09 21:54:40 UTC) #3
Robert Sesek
lgtm
8 years, 9 months ago (2012-03-09 22:08:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/9665017/2001
8 years, 9 months ago (2012-03-09 22:26:40 UTC) #5
commit-bot: I haz the power
Presubmit check for 9665017-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-09 22:26:43 UTC) #6
jam
lgtm
8 years, 9 months ago (2012-03-10 00:44:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/9665017/2001
8 years, 9 months ago (2012-03-10 00:48:32 UTC) #8
commit-bot: I haz the power
Try job failure for 9665017-2001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-10 03:06:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/9665017/2001
8 years, 9 months ago (2012-03-12 18:16:29 UTC) #10
commit-bot: I haz the power
Change committed as 126250
8 years, 9 months ago (2012-03-12 22:51:12 UTC) #11
Bernhard Bauer
8 years, 9 months ago (2012-03-19 15:08:28 UTC) #12
Wait, doesn't this mean that we load plug-ins from disk once for each call to
PluginLoaderPosix::LoadPlugins? That seems wrong. The whole point of queuing
requests is that we only need to load the plug-in list once.

Powered by Google App Engine
This is Rietveld 408576698