Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 9664050: Settings: Convert the WebUI Bidi tests to options2 implementation. (Closed)

Created:
8 years, 9 months ago by James Hawkins
Modified:
8 years, 9 months ago
Reviewers:
csilv
CC:
chromium-reviews
Visibility:
Public.

Description

Settings: Convert the WebUI Bidi tests to options2 implementation. BUG=112060 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126497

Patch Set 1 #

Patch Set 2 : Test disablement. #

Patch Set 3 : More. #

Patch Set 4 : Moar. #

Patch Set 5 : Mooar. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -75 lines) Patch
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 2 3 4 4 chunks +48 lines, -75 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Hawkins
8 years, 9 months ago (2012-03-11 23:09:15 UTC) #1
csilv
lgtm
8 years, 9 months ago (2012-03-12 18:21:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/9664050/9005
8 years, 9 months ago (2012-03-13 04:02:09 UTC) #3
commit-bot: I haz the power
Try job failure for 9664050-9005 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-13 04:57:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/9664050/9005
8 years, 9 months ago (2012-03-13 18:44:16 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 19:24:38 UTC) #6
Try job failure for 9664050-9005 (retry) on mac_rel for steps "crypto_unittests,
cacheinvalidation_unittests, printing_unittests, jingle_unittests, ui_tests,
remoting_unittests, browser_tests, net_unittests, unit_tests, gpu_unittests,
base_unittests, media_unittests, gfx_unittests, ipc_tests, sql_unittests,
safe_browsing_tests, content_unittests, sync_unit_tests".
It's a second try, previously, steps "crypto_unittests,
cacheinvalidation_unittests, printing_unittests, jingle_unittests, ui_tests,
remoting_unittests, browser_tests, net_unittests, unit_tests, gpu_unittests,
base_unittests, media_unittests, gfx_unittests, ipc_tests, sql_unittests,
safe_browsing_tests, content_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698