Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 9664008: Add Phone/Tablet device types for syncing session from Android. (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Add Phone/Tablet device types for syncing session from Android. This is most of the scaffolding. The logic to choose between Tablet/Phone requires Java code which can't be upstreamed yet due to other dependencies. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126762

Patch Set 1 #

Patch Set 2 : self-review #

Total comments: 2

Patch Set 3 : made function private #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 3 chunks +25 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/synced_session.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/protocol/proto_enum_conversions.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sync/protocol/session_specifics.proto View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yaron
8 years, 9 months ago (2012-03-09 18:54:43 UTC) #1
Nicolas Zea
http://codereview.chromium.org/9664008/diff/2001/chrome/browser/sync/glue/session_model_associator.h File chrome/browser/sync/glue/session_model_associator.h (right): http://codereview.chromium.org/9664008/diff/2001/chrome/browser/sync/glue/session_model_associator.h#newcode432 chrome/browser/sync/glue/session_model_associator.h:432: sync_pb::SessionHeader::DeviceType GetLocalDeviceType(); Does this have to be exposed via ...
8 years, 9 months ago (2012-03-14 18:27:13 UTC) #2
Yaron
Had to rebase, sorry http://codereview.chromium.org/9664008/diff/2001/chrome/browser/sync/glue/session_model_associator.h File chrome/browser/sync/glue/session_model_associator.h (right): http://codereview.chromium.org/9664008/diff/2001/chrome/browser/sync/glue/session_model_associator.h#newcode432 chrome/browser/sync/glue/session_model_associator.h:432: sync_pb::SessionHeader::DeviceType GetLocalDeviceType(); On 2012/03/14 18:27:14, ...
8 years, 9 months ago (2012-03-14 19:01:00 UTC) #3
Nicolas Zea
lgtm
8 years, 9 months ago (2012-03-14 19:20:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/9664008/7001
8 years, 9 months ago (2012-03-14 19:44:29 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-14 22:10:50 UTC) #6
Change committed as 126762

Powered by Google App Engine
This is Rietveld 408576698