Don't add devtools to list of startup pages

Don't add devtools to list of startup pages

BUG=117633
TEST=devtools not counted as a "current page"
R=estade@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126261

[Tyler Breisacher (Chromium), 2012-03-10 03:10:09]

Can you think of any other URLs we should exclude? I think it makes sense to
count most chrome:// URLs as a current page. Maybe the user wants to load
chrome://flags on startup for some reason.

[Evan Stade, 2012-03-10 03:11:48]

https://chromiumcodereview.appspot.com/9663044/diff/1/chrome/browser/custom_h...
File chrome/browser/custom_home_pages_table_model.cc (right):

https://chromiumcodereview.appspot.com/9663044/diff/1/chrome/browser/custom_h...
chrome/browser/custom_home_pages_table_model.cc:162: url.host() ==
chrome::kChromeUIUberHost)) &&
this seems wrong actually, you might want to have chrome://chrome/extensions
always show on startup

[Tyler Breisacher (Chromium), 2012-03-10 03:40:12]

Done.

[Evan Stade, 2012-03-10 03:45:02]

https://chromiumcodereview.appspot.com/9663044/diff/2001/chrome/browser/custo...
File chrome/browser/custom_home_pages_table_model.cc (right):

https://chromiumcodereview.appspot.com/9663044/diff/2001/chrome/browser/custo...
chrome/browser/custom_home_pages_table_model.cc:162:
url.spec().find("chrome://chrome/settings") != 0 &&
should use constant... how about checking path starts with
chrome::kChromeUISettingsHost or something

[Tyler Breisacher (Chromium), 2012-03-12 18:49:54]

Done.

[Evan Stade, 2012-03-12 20:14:11]

lgtm

http://codereview.chromium.org/9663044/diff/5002/chrome/browser/custom_home_p...
File chrome/browser/custom_home_pages_table_model.cc (right):

http://codereview.chromium.org/9663044/diff/5002/chrome/browser/custom_home_p...
chrome/browser/custom_home_pages_table_model.cc:44:
url.path().find(chrome::kChromeUISettingsHost) == 1) {
This also catches chrome://chrome/settings-foo

I guess it doesn't matter as we don't have any URLs of that form and it seems
unlikely (although not impossible) that we would ever start using one.

http://codereview.chromium.org/9663044/diff/5002/chrome/browser/custom_home_p...
chrome/browser/custom_home_pages_table_model.cc:185: if (ShouldAddPage(url)) {
no curlies

[commit-bot: I haz the power, 2012-03-12 20:17:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9663044/11001

[commit-bot: I haz the power, 2012-03-12 23:23:03]

Change committed as 126261