Add a boolean |had_context| argument to the TLS ExportKeyingMaterial

Add a boolean |has_context| argument to the TLS ExportKeyingMaterial
method to support both nonexistent context and zero-length context.

R=agl@chromium.org,rsleevi@chromium.org
BUG=none
TEST=existing unit tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126799

[Ryan Sleevi, 2012-03-10 04:23:31]

Rubberstamp LGTM, with a copy/pasted nit below, because it's so prevalent :) One
slight grammatical nit at the very bottom.

http://codereview.chromium.org/9663043/diff/1/net/socket/socket_test_util.cc
File net/socket/socket_test_util.cc (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/socket_test_util.cc#...
net/socket/socket_test_util.cc:693: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/socket_test_util.h
File net/socket/socket_test_util.h (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/socket_test_util.h#n...
net/socket/socket_test_util.h:601: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_ma...
File net/socket/ssl_client_socket_mac.cc (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_ma...
net/socket/ssl_client_socket_mac.cc:783: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_mac.h
File net/socket/ssl_client_socket_mac.h (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_ma...
net/socket/ssl_client_socket_mac.h:50: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_ns...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_ns...
net/socket/ssl_client_socket_nss.cc:544: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_nss.h
File net/socket/ssl_client_socket_nss.h (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_ns...
net/socket/ssl_client_socket_nss.h:67: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_op...
File net/socket/ssl_client_socket_openssl.cc (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_op...
net/socket/ssl_client_socket_openssl.cc:629: unsigned char *out, unsigned int
outlen) {
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_wi...
File net/socket/ssl_client_socket_win.cc (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_wi...
net/socket/ssl_client_socket_win.cc:545: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_win.h
File net/socket/ssl_client_socket_win.h (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_client_socket_wi...
net/socket/ssl_client_socket_win.h:54: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_server_socket_ns...
File net/socket/ssl_server_socket_nss.cc (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_server_socket_ns...
net/socket/ssl_server_socket_nss.cc:125: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_server_socket_nss.h
File net/socket/ssl_server_socket_nss.h (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_server_socket_ns...
net/socket/ssl_server_socket_nss.h:39: unsigned char *out,
nit: "unsigned char *" -> "unsigned char* "

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_socket.h
File net/socket/ssl_socket.h (right):

http://codereview.chromium.org/9663043/diff/1/net/socket/ssl_socket.h#newcode23
net/socket/ssl_socket.h:23: // the socket is not connected, or the SSL
implementation does not
nit: No comma needed here. If you do leave it, then ", or if"

[agl, 2012-03-12 15:22:20]

lgtm

http://codereview.chromium.org/9663043/diff/1/net/third_party/nss/ssl/sslinfo.c
File net/third_party/nss/ssl/sslinfo.c (right):

http://codereview.chromium.org/9663043/diff/1/net/third_party/nss/ssl/sslinfo...
net/third_party/nss/ssl/sslinfo.c:361: if (contextLen > 0) {
(very minor): I think that this if is superfluous, but you might feel that it
aids readability.

[wtc, 2012-03-14 03:35:45]

sergeyu: could you please review the change to
remoting/protocol/auth_util.cc in this CL?  Thanks.

http://codereview.chromium.org/9663043/diff/9001/remoting/protocol/auth_util.cc
File remoting/protocol/auth_util.cc (right):

http://codereview.chromium.org/9663043/diff/9001/remoting/protocol/auth_util....
remoting/protocol/auth_util.cc:50: label, false, "", key_material,
kAuthDigestLength);

Here we're using no context (""), so the new has_context
argument should be false.

[Sergey Ulanov, 2012-03-14 06:15:17]

src/remoting - LGTM

[commit-bot: I haz the power, 2012-03-14 15:01:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/9663043/9001

[commit-bot: I haz the power, 2012-03-14 15:04:30]

Try job failure for 9663043-9001 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-14 21:45:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/9663043/9001

[commit-bot: I haz the power, 2012-03-15 00:21:00]

Change committed as 126799