bluetooth: implement D-Bus service provider for Agent

bluetooth: implement D-Bus service provider for Agent

BlueZ requires that to connect to a remote device we provide a D-Bus
object with which it can interact during the pairing process known as
the Agent.

Implement the service provider for the Agent which interacts with its
Delegate class to provide the functionality BlueZ requires.

BUG=chromium-os:27101
TEST=emerge chromeos-chrome

Change-Id: Ica2273b217952e960a18e6885e1fff67ade5d0ce


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126205

[satorux1, 2012-03-12 16:57:27]

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
File chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc (right):

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:27: }
nit: }  // namespace

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:442: }
nit:

default:
  NOTREACHED() << "Unexpected status code: " << status;

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:472: }
ditto.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:499: }
ditto

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
File chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h (right):

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:18: class
BluetoothAgentServiceProvider {
class comment is missing. what this class is for?

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:50: typedef
base::Callback<void(Status, const std::string&)> PinCodeCallback;
nit: please add parameter names.

base::Callback<void(Status status, const std::string& pincode)>

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:56: typedef
base::Callback<void(Status, uint32)> PasskeyCallback;
ditto

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:154: //
TODO(keybuk): docs.
fix the todo now?

[keybuk, 2012-03-12 17:30:03]

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
File chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc (right):

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:27: }
On 2012/03/12 16:57:27, satorux1 wrote:
> nit: }  // namespace

Done.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:442: }
On 2012/03/12 16:57:27, satorux1 wrote:
> nit:
> 
> default:
>   NOTREACHED() << "Unexpected status code: " << status;

Done.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:472: }
On 2012/03/12 16:57:27, satorux1 wrote:
> ditto.

Done.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.cc:499: }
On 2012/03/12 16:57:27, satorux1 wrote:
> ditto

Done.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
File chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h (right):

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:18: class
BluetoothAgentServiceProvider {
On 2012/03/12 16:57:27, satorux1 wrote:
> class comment is missing. what this class is for?

Done.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:50: typedef
base::Callback<void(Status, const std::string&)> PinCodeCallback;
Chrome style seems to be to NOT use these, there are very very few instances in
the code where callback typedefs have method names.

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:56: typedef
base::Callback<void(Status, uint32)> PasskeyCallback;
as above, seems contrary to Chrome style

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:154: //
TODO(keybuk): docs.
On 2012/03/12 16:57:27, satorux1 wrote:
> fix the todo now?

Done.

[satorux1, 2012-03-12 17:55:30]

LGTM

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
File chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h (right):

http://codereview.chromium.org/9663035/diff/1/chrome/browser/chromeos/dbus/bl...
chrome/browser/chromeos/dbus/bluetooth_agent_service_provider.h:50: typedef
base::Callback<void(Status, const std::string&)> PinCodeCallback;
On 2012/03/12 17:30:03, keybuk wrote:
> Chrome style seems to be to NOT use these, there are very very few instances
in
> the code where callback typedefs have method names.

Our style guide doesn't say anything about it. My guess is that it was
historically omitted for no particular reason, and we don't need to follow it.

"Status status" may look obvious, but "const std::string& pincode" makes it
easier to understand. This extra information is especially useful when there are
multiple string parameters.

However, it's not worth debating, so I don't insist.

[commit-bot: I haz the power, 2012-03-12 18:16:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/9663035/3002

[commit-bot: I haz the power, 2012-03-12 20:35:38]

Change committed as 126205