Fix a buffer length bug and nits in the next protocol negotiation (NPN)

Fix a buffer length bug and nits in the next protocol negotiation (NPN)
functions.

R=agl@chromium.org
BUG=116617
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126239

[wtc, 2012-03-10 00:43:15]

https://chromiumcodereview.appspot.com/9663034/diff/1/net/third_party/nss/ssl...
File net/third_party/nss/ssl/ssl3ext.c (left):

https://chromiumcodereview.appspot.com/9663034/diff/1/net/third_party/nss/ssl...
net/third_party/nss/ssl/ssl3ext.c:609: if (ss->firstHsDone) {

ss->firstHsDone cannot be true here.  Line 650 below ensures
that we (an NSS client) do not send the NPN extension if
ss->firstHsDone is true, and NSS won't call an extension
handler on the client side if the server sends an unadvertised
extension.

https://chromiumcodereview.appspot.com/9663034/diff/1/net/third_party/nss/ssl...
File net/third_party/nss/ssl/ssl3ext.c (right):

https://chromiumcodereview.appspot.com/9663034/diff/1/net/third_party/nss/ssl...
net/third_party/nss/ssl/ssl3ext.c:633: if (result.len > sizeof resultBuffer) {

This is the fix for the buffer length bug.  We will hit this
bug if the NPN result is larger than the size of SECItem
(12 bytes).

[agl, 2012-03-12 15:18:27]

LGTM. Thanks!

[commit-bot: I haz the power, 2012-03-12 19:07:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/9663034/1

[commit-bot: I haz the power, 2012-03-12 21:35:36]

Change committed as 126239