Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 9663033: Debug flaky gpu pixel tests by printing event trace on failure. (Closed)

Created:
8 years, 9 months ago by jbates
Modified:
8 years, 9 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews
Visibility:
Public.

Description

Debug flaky gpu pixel tests by printing event trace on failure. R=zmo Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126187

Patch Set 1 #

Total comments: 2

Patch Set 2 : zmo feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/test/data/gpu/pixel_canvas2d.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 3 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jbates
8 years, 9 months ago (2012-03-10 00:18:11 UTC) #1
Zhenyao Mo
On 2012/03/10 00:18:11, jbates wrote: LGTM
8 years, 9 months ago (2012-03-10 01:12:46 UTC) #2
Zhenyao Mo
https://chromiumcodereview.appspot.com/9663033/diff/1/chrome/test/gpu/gpu_pixel_browsertest.cc File chrome/test/gpu/gpu_pixel_browsertest.cc (right): https://chromiumcodereview.appspot.com/9663033/diff/1/chrome/test/gpu/gpu_pixel_browsertest.cc#newcode163 chrome/test/gpu/gpu_pixel_browsertest.cc:163: fprintf(stderr, "\n\nTRACE JSON:\n\n%s\n\n", trace_events.c_str()); It's worth adding a comment ...
8 years, 9 months ago (2012-03-10 01:12:51 UTC) #3
jbates
https://chromiumcodereview.appspot.com/9663033/diff/1/chrome/test/gpu/gpu_pixel_browsertest.cc File chrome/test/gpu/gpu_pixel_browsertest.cc (right): https://chromiumcodereview.appspot.com/9663033/diff/1/chrome/test/gpu/gpu_pixel_browsertest.cc#newcode163 chrome/test/gpu/gpu_pixel_browsertest.cc:163: fprintf(stderr, "\n\nTRACE JSON:\n\n%s\n\n", trace_events.c_str()); On 2012/03/10 01:12:51, Zhenyao Mo ...
8 years, 9 months ago (2012-03-12 17:32:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/9663033/2003
8 years, 9 months ago (2012-03-12 17:33:13 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 19:23:33 UTC) #6
Change committed as 126187

Powered by Google App Engine
This is Rietveld 408576698