Add database recovery for FileSystemOriginDatabase

webkit/fileapi/file_system_origin_database.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_origin_database.h"
 
+#include "base/file_util.h"
 #include "base/format_macros.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "third_party/leveldatabase/src/include/leveldb/iterator.h"
 #include "third_party/leveldatabase/src/include/leveldb/write_batch.h"
 
 namespace {
 
+const FilePath::CharType kOriginDatabaseName[] = FILE_PATH_LITERAL("Origins");
 const char kOriginKeyPrefix[] = "ORIGIN:";
 const char kLastPathKey[] = "LAST_PATH";
 
 std::string OriginToOriginKey(const std::string& origin) {
   std::string key(kOriginKeyPrefix);
   return key + origin;
 }
 
 const char* LastPathKey() {
   return kLastPathKey;
 }
 
 }
 
 namespace fileapi {
 
 FileSystemOriginDatabase::OriginRecord::OriginRecord() {
 }
 
 FileSystemOriginDatabase::OriginRecord::OriginRecord(
     const std::string& origin_in, const FilePath& path_in)
     : origin(origin_in), path(path_in) {
 }
 
 FileSystemOriginDatabase::OriginRecord::~OriginRecord() {
 }
 
-FileSystemOriginDatabase::FileSystemOriginDatabase(const FilePath& path) {
-#if defined(OS_POSIX)
-  path_ = path.value();
-#elif defined(OS_WIN)
-  path_ = base::SysWideToUTF8(path.value());
-#endif
+FileSystemOriginDatabase::FileSystemOriginDatabase(
+    const FilePath& file_system_directory)
+    : file_system_directory_(file_system_directory) {
 }
 
 FileSystemOriginDatabase::~FileSystemOriginDatabase() {
 }
 
-bool FileSystemOriginDatabase::Init() {
+bool FileSystemOriginDatabase::Init(RecoveryOption recovery_option) {
   if (db_.get())
     return true;
 
+  std::string path;
+#if defined(OS_POSIX)
+  path = file_system_directory_.Append(kOriginDatabaseName).value();
+#elif defined(OS_WIN)
+  path = base::SysWideToUTF8(
+      file_system_directory_.Append(kOriginDatabaseName).value());
+#else
+  NOTREACHED();
+#endif
+
   leveldb::Options options;
   options.create_if_missing = true;
   leveldb::DB* db;
-  leveldb::Status status = leveldb::DB::Open(options, path_, &db);
+  leveldb::Status status = leveldb::DB::Open(options, path, &db);
+  // TODO(tzik): Collect status metrics here.
   if (status.ok()) {
     db_.reset(db);
     return true;
   }
   HandleError(FROM_HERE, status);
-  return false;
+
+  if (recovery_option == FAIL_ON_CORRUPTION)
+    return false;
+
+  if (recovery_option == REPAIR_ON_CORRUPTION && RepairDB(path))

[ericu, 2012/03/22 03:54:17]

The changes the semantics of REPAIR_ON_CORRUPTION to fall back to DELETE if it
fails.  Before it fell back to FAIL.  I think that's the right decision, but I
just wanted to confirm that that was your intention.

[tzik, 2012/03/22 14:56:27]

Yes, it's intentional.
Repairing is destructive operation, so after its failure, we need to cleanup.

+    return true;
+
+  DCHECK(DELETE_ON_CORRUPTION == recovery_option ||
+         REPAIR_ON_CORRUPTION == recovery_option);
+  DropDatabase();

[ericu, 2012/03/22 03:54:17]

The DropDatabase shouldn't be needed; nothing should have set db_, and it was
NULL at line 57.

[tzik, 2012/03/22 14:56:27]

Done.

+  if (!file_util::Delete(file_system_directory_, true))
+    return false;
+  if (!file_util::CreateDirectory(file_system_directory_))
+    return false;
+
+  return Init(FAIL_ON_CORRUPTION);
+}
+
+bool FileSystemOriginDatabase::RepairDB(const std::string& db_path) {
+  DCHECK(!db_.get());
+  if (!leveldb::RepairDB(db_path, leveldb::Options()).ok())
+    return false;
+  if (!Init(FAIL_ON_CORRUPTION))
+    return false;
+
+  std::set<FilePath> directories;
+  file_util::FileEnumerator file_enum(file_system_directory_,
+                                      false /* recursive */,
+                                      file_util::FileEnumerator::DIRECTORIES);
+  FilePath path_each;
+  while (!(path_each = file_enum.Next()).empty())
+    directories.insert(path_each.BaseName());
+  std::set<FilePath>::iterator db_dir_itr =
+      directories.find(FilePath(kOriginDatabaseName));
+  DCHECK(db_dir_itr != directories.end());
+  directories.erase(db_dir_itr);
+
+  std::vector<OriginRecord> origins;
+  if (!ListAllOrigins(&origins))
+    return false;
+  for (std::vector<OriginRecord>::iterator db_origin_itr = origins.begin();
+       db_origin_itr != origins.end();
+       ++db_origin_itr) {
+    std::set<FilePath>::iterator dir_itr =
+        directories.find(db_origin_itr->path);
+    if (dir_itr != directories.end()) {
+      if (!RemovePathForOrigin(db_origin_itr->origin))
+        return false;
+      directories.erase(dir_itr);
+    }
+  }
+
+  //Delete any directories not listed in the origins database.
+  for (std::set<FilePath>::iterator dir_itr = directories.begin();
+       dir_itr != directories.end();
+       ++dir_itr)
+    if (!file_util::Delete(file_system_directory_.Append(*dir_itr),
+                           true /* recursive */))
+      return false;
+
+  return true;
 }
 
 void FileSystemOriginDatabase::HandleError(
     const tracked_objects::Location& from_here, leveldb::Status status) {
   db_.reset();
   LOG(ERROR) << "FileSystemOriginDatabase failed at: "
              << from_here.ToString() << " with error: " << status.ToString();
 }
 
 bool FileSystemOriginDatabase::HasOriginPath(const std::string& origin) {
-  if (!Init())
+  if (!Init(REPAIR_ON_CORRUPTION))
     return false;
   if (origin.empty())
     return false;
   std::string path;
   leveldb::Status status =
       db_->Get(leveldb::ReadOptions(), OriginToOriginKey(origin), &path);
   if (status.ok())
     return true;
   if (status.IsNotFound())
     return false;
   HandleError(FROM_HERE, status);
   return false;
 }
 
 bool FileSystemOriginDatabase::GetPathForOrigin(
     const std::string& origin, FilePath* directory) {
-  if (!Init())
+  if (!Init(REPAIR_ON_CORRUPTION))
     return false;
   DCHECK(directory);
   if (origin.empty())
     return false;
   std::string path_string;
   std::string origin_key = OriginToOriginKey(origin);
   leveldb::Status status =
       db_->Get(leveldb::ReadOptions(), origin_key, &path_string);
   if (status.IsNotFound()) {
     int last_path_number;
@@ skipping 16 matching lines @@
 #elif defined(OS_WIN)
     *directory = FilePath(base::SysUTF8ToWide(path_string));
 #endif
     return true;
   }
   HandleError(FROM_HERE, status);
   return false;
 }
 
 bool FileSystemOriginDatabase::RemovePathForOrigin(const std::string& origin) {
-  if (!Init())
+  if (!Init(REPAIR_ON_CORRUPTION))
     return false;
   leveldb::Status status =
       db_->Delete(leveldb::WriteOptions(), OriginToOriginKey(origin));
   if (status.ok() || status.IsNotFound())
     return true;
   HandleError(FROM_HERE, status);
   return false;
 }
 
 bool FileSystemOriginDatabase::ListAllOrigins(
     std::vector<OriginRecord>* origins) {
-  if (!Init())
+  if (!Init(REPAIR_ON_CORRUPTION))
     return false;
   DCHECK(origins);
   scoped_ptr<leveldb::Iterator> iter(db_->NewIterator(leveldb::ReadOptions()));
   std::string origin_key_prefix = OriginToOriginKey("");
   iter->Seek(origin_key_prefix);
   origins->clear();
   while(iter->Valid() &&
       StartsWithASCII(iter->key().ToString(), origin_key_prefix, true)) {
     std::string origin =
       iter->key().ToString().substr(origin_key_prefix.length());
 #if defined(OS_POSIX)
     FilePath path = FilePath(iter->value().ToString());
 #elif defined(OS_WIN)
     FilePath path = FilePath(base::SysUTF8ToWide(iter->value().ToString()));
 #endif
     origins->push_back(OriginRecord(origin, path));
     iter->Next();
   }
   return true;
 }
 
 void FileSystemOriginDatabase::DropDatabase() {
   db_.reset();
 }
 
 bool FileSystemOriginDatabase::GetLastPathNumber(int* number) {
-  if (!Init())
+  if (!Init(REPAIR_ON_CORRUPTION))
     return false;
   DCHECK(number);
   std::string number_string;
   leveldb::Status status =
       db_->Get(leveldb::ReadOptions(), LastPathKey(), &number_string);
   if (status.ok())
     return base::StringToInt(number_string, number);
   if (!status.IsNotFound()) {
     HandleError(FROM_HERE, status);
     return false;
@@ skipping 11 matching lines @@
       db_->Put(leveldb::WriteOptions(), LastPathKey(), std::string("-1"));
   if (!status.ok()) {
     HandleError(FROM_HERE, status);
     return false;
   }
   *number = -1;
   return true;
 }
 
 }  // namespace fileapi