src/runtime.cc - Issue 9663002: Use CopyElements for SetFastDoubleElementsCapacityAndLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 9663002: Use CopyElements for SetFastDoubleElementsCapacityAndLength (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Review feedback Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index d8b9702bf3a7e759ec6723cf9169b37f679fac96..6e93e58620d04564d04255dcef9571b17540b104 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -6769,6 +6769,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_StringBuilderConcat) {

ascii = false;

}

} else {

+ ASSERT(!elt->IsTheHole());

return isolate->Throw(isolate->heap()->illegal_argument_symbol());

}

if (increment > String::kMaxLength - position) {

« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »