Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 9662055: Test for --nacl-gdb functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('j') | ppapi/tests/test_empty.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/nacl_host/nacl_process_host.cc
===================================================================
--- chrome/browser/nacl_host/nacl_process_host.cc (revision 126069)
+++ chrome/browser/nacl_host/nacl_process_host.cc (working copy)
@@ -279,7 +279,12 @@
}
#if defined(OS_WIN)
if (RunningOnWOW64()) {
- NaClBrokerService::GetInstance()->OnLoaderDied();
+ // If nacl-gdb switch is not empty, NaCl loader has been launched
+ // without broker and so we shouldn't inform broker about its termination.
+ if (CommandLine::ForCurrentProcess()->GetSwitchValuePath(
+ switches::kNaClGdb).empty()) {
+ NaClBrokerService::GetInstance()->OnLoaderDied();
+ }
} else {
debug_context_->SetChildProcessHost(NULL);
}
« no previous file with comments | « no previous file | chrome/browser/nacl_host/test/mock_nacl_gdb.cc » ('j') | ppapi/tests/test_empty.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698