Test for --nacl-gdb functionality.

chrome/browser/nacl_host/nacl_gdb_browsertest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/command_line.h"
+#include "base/path_service.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/test/ui/ppapi_uitest.h"
+
+#if defined(OS_WIN)
+static const FilePath::CharType kMockNaClGdb[] =

[Mark Seaborn, 2012/03/13 01:05:20]

You could move this line outside of the #if.

[halyavin, 2012/03/13 12:48:27]

Done.

+    FILE_PATH_LITERAL("mock_nacl_gdb.exe");
+#else
+static const FilePath::CharType kMockNaClGdb[] =
+    FILE_PATH_LITERAL("mock_nacl_gdb");
+#endif
+
+class NaClGdbTest : public PPAPINaClTest {
+ public:
+  NaClGdbTest() {
+  }
+
+  void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+    PPAPINaClTest::SetUpCommandLine(command_line);
+
+    command_line->AppendSwitch(switches::kNoSandbox);

[Mark Seaborn, 2012/03/13 01:05:20]

I thought this gets added automatically when using --nacl-gdb?

[halyavin, 2012/03/13 12:48:27]

Sorry, I knew that this should be removed but forgot to do it.

+    FilePath mock_nacl_gdb;
+    EXPECT_TRUE(PathService::Get(base::DIR_EXE, &mock_nacl_gdb));
+    mock_nacl_gdb = mock_nacl_gdb.Append(kMockNaClGdb);
+    command_line->AppendSwitchPath(switches::kNaClGdb, mock_nacl_gdb);

[Mark Seaborn, 2012/03/13 01:05:20]

What happens if Chromium ignores the --nacl-gdb argument?  How does this test
assert that nacl-gdb gets invokved?

[Mark Seaborn, 2012/03/13 17:06:27]

Andrey, you didn't answer this question.  This is the main thing I don't
understand about this change.

+  }
+};
+
+IN_PROC_BROWSER_TEST_F(NaClGdbTest, Empty) {
+  RunTestViaHTTP("Empty");
+}