chrome/browser/nacl_host/mock_nacl_gdb.gyp - Issue 9662055: Test for --nacl-gdb functionality.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/nacl_host/mock_nacl_gdb.gyp

Issue 9662055: Test for --nacl-gdb functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/nacl_host/mock_nacl_gdb.cc ('K') | « chrome/browser/nacl_host/mock_nacl_gdb.cc ('k') | chrome/browser/nacl_host/nacl_gdb_browsertest.cc » ('j') | chrome/browser/nacl_host/nacl_gdb_browsertest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4 {

	5 'conditions': [

	6 ['disable_nacl==0 and OS=="win"', {
	Mark Seaborn 2012/03/13 01:05:20 Why Windows-only? I was under the impression that Why Windows-only? I was under the impression that your change to nacl_process_host.cc worked for Linux too, and your nacl64-gdb works on Linux. halyavin 2012/03/13 12:48:27 The change to nacl_process_host.cc doesn't work un Show quoted text On 2012/03/13 01:05:20, Mark Seaborn wrote: > Why Windows-only? I was under the impression that your change to > nacl_process_host.cc worked for Linux too, and your nacl64-gdb works on Linux. The change to nacl_process_host.cc doesn't work under Linux. I am investigating this problem. Mark Seaborn 2012/03/13 17:06:27 OK, in the mean time please add TODOs next to the Show quoted text On 2012/03/13 12:48:27, halyavin wrote: > On 2012/03/13 01:05:20, Mark Seaborn wrote: > > Why Windows-only? I was under the impression that your change to > > nacl_process_host.cc worked for Linux too, and your nacl64-gdb works on Linux. > > The change to nacl_process_host.cc doesn't work under Linux. I am > investigating this problem. OK, in the mean time please add TODOs next to the 'OS=="win"' cases.
	7 'targets': [

	8 {

	9 'target_name': 'mock_nacl_gdb',

	10 'type': 'executable',

	11 'include_dirs': [

	12 '../../..',

	13 ],

	14 'sources': [

	15 'mock_nacl_gdb.cc',

	16 ],

	17 'dependencies': [

	18 '../../../base/base.gyp:base',

	19 ],

	20 },

	21 ],

	22 }],

	23 ],

	24 }

OLD	NEW