Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 9662026: Move constructor and destructor of GLES2CmdHelper out of line (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Move constructor and destructor of GLES2CmdHelper out of line This makes the cc file a bit less pointless and also removes a (harmless) "no symbols defined in static library" build warning in mac. gles2_conform_support/egl/display.h uses GLES2CmdHelper, so add a dependency from egl_native to gles2_cmd_helper to fix a dependency issue exposed by this change. BUG=none TEST=temporary ocd relief Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126304

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : components #

Patch Set 4 : . #

Patch Set 5 : export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M gpu/command_buffer/client/gles2_cmd_helper.h View 1 2 3 4 2 chunks +4 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper.cc View 1 chunk +8 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gpu_common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Nico
8 years, 9 months ago (2012-03-10 01:06:36 UTC) #1
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-10 02:08:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9662026/1
8 years, 9 months ago (2012-03-10 02:09:12 UTC) #3
commit-bot: I haz the power
Try job failure for 9662026-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-10 02:44:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9662026/4002
8 years, 9 months ago (2012-03-10 05:18:03 UTC) #5
commit-bot: I haz the power
Try job failure for 9662026-4002 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-10 06:02:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9662026/3006
8 years, 9 months ago (2012-03-10 06:12:56 UTC) #7
commit-bot: I haz the power
Try job failure for 9662026-3006 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-10 06:46:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9662026/8001
8 years, 9 months ago (2012-03-12 18:46:11 UTC) #9
commit-bot: I haz the power
Try job failure for 9662026-8001 (retry) on win_rel for steps "ui_tests, browser_tests, check_deps". It's a ...
8 years, 9 months ago (2012-03-12 22:16:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9662026/8001
8 years, 9 months ago (2012-03-12 22:24:01 UTC) #11
commit-bot: I haz the power
Try job failure for 9662026-8001 (retry) on linux_rel for step "check_deps". It's a second try, ...
8 years, 9 months ago (2012-03-12 23:19:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9662026/8001
8 years, 9 months ago (2012-03-12 23:20:38 UTC) #13
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 02:02:12 UTC) #14
Change committed as 126304

Powered by Google App Engine
This is Rietveld 408576698