Added depot_tools/utils, added util to prune dead git branches

Added depot_tools/git-utils, added util to prune dead git branches

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127515

[groby-ooo-7-16, 2012-03-08 21:52:48]

First python submission, so I'm sorry if I'm missing obvious steps.

Specifically, gcl upload had a bunch of complaints that I don't know how to fix:


    ************* Module trychange_unittest
    E1103:111,4:SVNUnittest.testBasic: Instance of 'str' has no 'AndReturn'
member (but some types could not be inferred)
    E1103:112,4:SVNUnittest.testBasic: Instance of 'str' has no 'AndReturn'
member (but some types could not be inferred)


trychange_unittest is "none of mine".

    You should install python 2.5

I would - but python 2.5 complains:

    presubmit_canned_checks.py:469: Warning: 'as' will become a reserved keyword
in Python 2.6
    ...
    presubmit_canned_checks.py", line 469
    except IOError as e:
                        ^
    SyntaxError: invalid syntax

[M-A Ruel, 2012-03-13 14:16:02]

One thing I'm wondering and the reason I had initially posponned the review;

I feel using a "util" directory name is not really useful. I'd prefer something
like "git-stuff" or "git-utils" to make this clear.

Also, I prefer git utility scripts to keep the git-foo style, so something like
git-tree-prune, without a .py post fix.

wdyt?

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py
File utils/tree-prune.py (right):

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode11
utils/tree-prune.py:11: try:
Using this instead;

BASE_DIR = os.path.dirname(os.path.abspath(__file__))
DEPOT_TOOLS_DIR = os.path.dirname(BASE_DIR)
sys.path.insert(0, DEPOT_TOOLS_DIR)

import git_cl

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode17
utils/tree-prune.py:17: import urllib2
Keep it grouped with system lib imports

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode19
utils/tree-prune.py:19: def GetBranches():
use PEP-8 style function naming, namely;

def get_branches():

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode22
utils/tree-prune.py:22: for branch_name in git_cl.RunGit(["branch"]).split():
splitlines()

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode23
utils/tree-prune.py:23: if branch_name != '*':
Use branch_name[3:] instead

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode25
utils/tree-prune.py:25: return result
So in the end, the function looks like this:

return [Branch(l[2:]) for l in git_cl.RunGit(["branch"]).splitlines()]

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode30
utils/tree-prune.py:30: git_cl.Changelist.__init__(self, branchref = name)
argument default values don't have space, e.g.

branchref=name

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode35
utils/tree-prune.py:35: if self.GetIssue() is not None:
if self.GetIssue():

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode49
utils/tree-prune.py:49: 
2 lines between file level symbols

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode69
utils/tree-prune.py:69: 
remove extra line

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode80
utils/tree-prune.py:80: 
add line

[groby-ooo-7-16, 2012-03-14 20:39:51]

Renames done, issues fix. Round 2! :)

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py
File utils/tree-prune.py (right):

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode11
utils/tree-prune.py:11: try:
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> Using this instead;
> 
> BASE_DIR = os.path.dirname(os.path.abspath(__file__))
> DEPOT_TOOLS_DIR = os.path.dirname(BASE_DIR)
> sys.path.insert(0, DEPOT_TOOLS_DIR)
> 
> import git_cl

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode17
utils/tree-prune.py:17: import urllib2
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> Keep it grouped with system lib imports

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode19
utils/tree-prune.py:19: def GetBranches():
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> use PEP-8 style function naming, namely;
> 
> def get_branches():

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode22
utils/tree-prune.py:22: for branch_name in git_cl.RunGit(["branch"]).split():
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> splitlines()

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode23
utils/tree-prune.py:23: if branch_name != '*':
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> Use branch_name[3:] instead

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode25
utils/tree-prune.py:25: return result
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> So in the end, the function looks like this:
> 
> return [Branch(l[2:]) for l in git_cl.RunGit(["branch"]).splitlines()]

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode30
utils/tree-prune.py:30: git_cl.Changelist.__init__(self, branchref = name)
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> argument default values don't have space, e.g.
> 
> branchref=name

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode35
utils/tree-prune.py:35: if self.GetIssue() is not None:
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> if self.GetIssue():

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode49
utils/tree-prune.py:49: 
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> 2 lines between file level symbols

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode69
utils/tree-prune.py:69: 
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> remove extra line

Done.

http://codereview.chromium.org/9657005/diff/1/utils/tree-prune.py#newcode80
utils/tree-prune.py:80: 
On 2012/03/13 14:16:02, Marc-Antoine Ruel wrote:
> add line

Done.

[M-A Ruel, 2012-03-15 15:27:13]

lgtm

https://chromiumcodereview.appspot.com/9657005/diff/5002/git-utils/git-tree-p...
File git-utils/git-tree-prune (right):

https://chromiumcodereview.appspot.com/9657005/diff/5002/git-utils/git-tree-p...
git-utils/git-tree-prune:6: """ A tool for listing branches with closed and
abandoned issues."""
"""A

https://chromiumcodereview.appspot.com/9657005/diff/5002/git-utils/git-tree-p...
git-utils/git-tree-prune:22: 
2 vertical lines between file level symbols

[groby-ooo-7-16, 2012-03-19 19:24:49]

https://chromiumcodereview.appspot.com/9657005/diff/5002/git-utils/git-tree-p...
File git-utils/git-tree-prune (right):

https://chromiumcodereview.appspot.com/9657005/diff/5002/git-utils/git-tree-p...
git-utils/git-tree-prune:6: """ A tool for listing branches with closed and
abandoned issues."""
On 2012/03/15 15:27:13, Marc-Antoine Ruel wrote:
> """A

Done.

https://chromiumcodereview.appspot.com/9657005/diff/5002/git-utils/git-tree-p...
git-utils/git-tree-prune:22: 
On 2012/03/15 15:27:13, Marc-Antoine Ruel wrote:
> 2 vertical lines between file level symbols

Done.

[commit-bot: I haz the power, 2012-03-19 19:25:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/9657005/9001

[commit-bot: I haz the power, 2012-03-19 19:30:59]

Change committed as 127515