Start using Dart_PropagateError in the runtime/bin directory.

runtime/bin/socket.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/socket.h"
 #include "bin/dartutils.h"
 
 #include "platform/utils.h"
 
 #include "include/dart_api.h"
@@ skipping 30 matching lines @@
       DartUtils::GetIntegerField(Dart_GetNativeArgument(args, 0),
                                  DartUtils::kIdFieldName);
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
   ASSERT(Dart_IsList(buffer_obj));
   intptr_t offset =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
   intptr_t length =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
   intptr_t buffer_len = 0;
   Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
-  ASSERT(!Dart_IsError(result));
+  if (Dart_IsError(result)) {
+    Dart_PropagateError(result);
+  }
   ASSERT((offset + length) <= buffer_len);
 
   if (Dart_IsVMFlagSet("short_socket_read")) {
     length = (length + 1) / 2;
   }
 
   uint8_t* buffer = new uint8_t[length];
   intptr_t bytes_read = Socket::Read(socket, buffer, length);
   if (bytes_read > 0) {
     Dart_Handle result =
         Dart_ListSetAsBytes(buffer_obj, offset, buffer, bytes_read);
     if (Dart_IsError(result)) {

[Søren Gjesse, 2012/03/08 21:18:46]

Missing delete[] buffer

-      bytes_read = -1;
+      Dart_PropagateError(result);
     }
   }
   delete[] buffer;
   Dart_SetReturnValue(args, Dart_NewInteger(bytes_read));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(Socket_WriteList)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t socket =
       DartUtils::GetIntegerField(Dart_GetNativeArgument(args, 0),
                                  DartUtils::kIdFieldName);
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
   ASSERT(Dart_IsList(buffer_obj));
   intptr_t offset =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
   intptr_t length =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
   intptr_t buffer_len = 0;
   Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
-  ASSERT(!Dart_IsError(result));
+  if (Dart_IsError(result)) {
+    Dart_PropagateError(result);
+  }
   ASSERT((offset + length) <= buffer_len);
 
   if (Dart_IsVMFlagSet("short_socket_write")) {
     length = (length + 1) / 2;
   }
 
   // Send data in chunks of maximum 16KB.
   const intptr_t max_chunk_length =
       dart::Utils::Minimum(length, static_cast<intptr_t>(16 * KB));
   uint8_t* buffer = new uint8_t[max_chunk_length];
   intptr_t total_bytes_written = 0;
   intptr_t bytes_written = 0;
   do {
     intptr_t chunk_length =
         dart::Utils::Minimum(max_chunk_length, length - total_bytes_written);
     result = Dart_ListGetAsBytes(buffer_obj,
                                  offset + total_bytes_written,
                                  buffer,
                                  chunk_length);
-    ASSERT(!Dart_IsError(result));
+    if (Dart_IsError(result)) {

[Søren Gjesse, 2012/03/08 21:18:46]

Missing delete[] buffer.

+      Dart_PropagateError(result);
+    }
     bytes_written =
         Socket::Write(socket, reinterpret_cast<void*>(buffer), chunk_length);
     total_bytes_written += bytes_written;
   } while (bytes_written > 0 && total_bytes_written < length);
   delete[] buffer;
   Dart_SetReturnValue(args, Dart_NewInteger(total_bytes_written));
   Dart_ExitScope();
 }
 
 
@@ skipping 46 matching lines @@
                                  DartUtils::kIdFieldName);
   Dart_Handle socketobj = Dart_GetNativeArgument(args, 1);
   intptr_t newSocket = ServerSocket::Accept(socket);
   if (newSocket >= 0) {
     DartUtils::SetIntegerField(
         socketobj, DartUtils::kIdFieldName, newSocket);
   }
   Dart_SetReturnValue(args, Dart_NewBoolean(newSocket >= 0));
   Dart_ExitScope();
 }