Start using Dart_PropagateError in the runtime/bin directory.

runtime/bin/file.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/file.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 
@@ skipping 161 matching lines @@
   File* file = reinterpret_cast<File*>(value);
   if (file != NULL) {
     Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
     ASSERT(Dart_IsList(buffer_obj));
     int64_t offset =
         DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
     int64_t length =
         DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
     intptr_t array_len = 0;
     Dart_Handle result = Dart_ListLength(buffer_obj, &array_len);
-    ASSERT(!Dart_IsError(result));
+    if (Dart_IsError(result)) {
+      Dart_PropagateError(result);
+    }
     ASSERT((offset + length) <= array_len);
     uint8_t* buffer = new uint8_t[length];
     int total_bytes_read =
         file->Read(reinterpret_cast<void*>(buffer), length);
     /*
      * Reading 0 indicates end of file.
      */
     if (total_bytes_read >= 0) {
       result =
           Dart_ListSetAsBytes(buffer_obj, offset, buffer, total_bytes_read);
-      if (!Dart_IsError(result)) {
-        return_value = total_bytes_read;
+      if (Dart_IsError(result)) {

[Søren Gjesse, 2012/03/08 21:18:46]

Missing delete[] buffer.

[turnidge, 2012/03/08 22:19:26]

Done.

+        Dart_PropagateError(result);
       }
+      return_value = total_bytes_read;
     }
     delete[] buffer;
   }
   Dart_SetReturnValue(args, Dart_NewInteger(return_value));
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(File_WriteList)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t return_value = -1;
   intptr_t value =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 0));
   File* file = reinterpret_cast<File*>(value);
   if (file != NULL) {
     Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
     ASSERT(Dart_IsList(buffer_obj));
     int64_t offset =
         DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
     int64_t length =
         DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
     intptr_t buffer_len = 0;
     Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
-    ASSERT(!Dart_IsError(result));
+    if (Dart_IsError(result)) {
+      Dart_PropagateError(result);
+    }
     ASSERT((offset + length) <= buffer_len);
     uint8_t* buffer = new uint8_t[length];
     result = Dart_ListGetAsBytes(buffer_obj, offset, buffer, length);
-    ASSERT(!Dart_IsError(result));
+    if (Dart_IsError(result)) {

[Søren Gjesse, 2012/03/08 21:18:46]

Missing delete[] buffer.

[turnidge, 2012/03/08 22:19:26]

Done.

+      Dart_PropagateError(result);
+    }
     int total_bytes_written =
         file->Write(reinterpret_cast<void*>(buffer), length);
     if (total_bytes_written >= 0) {
       return_value = total_bytes_written;
     }
     delete[] buffer;
   }
   Dart_SetReturnValue(args, Dart_NewInteger(return_value));
   Dart_ExitScope();
 }
@@ skipping 525 matching lines @@
   Dart_EnterScope();
   Dart_SetReturnValue(args, Dart_Null());
   Dart_Port service_port = File::GetServicePort();
   if (service_port != kIllegalPort) {
     // Return a send port for the service port.
     Dart_Handle send_port = Dart_NewSendPort(service_port);
     Dart_SetReturnValue(args, send_port);
   }
   Dart_ExitScope();
 }