Fix a crash related to PPAPI scripting.

Fix a crash related to PPAPI scripting.
SerializedVar and MessageChannel didn't properly handle the case that the dispatcher goes away while waiting for the reply to a sync message.

BUG=110095
TEST=When click the Test button on ppapi/example/example.html, the plugin is removed but the renderer doesn't crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126014

[yzshen1, 2012-03-09 04:29:01]

Hi, Brett.

Would you please take a look?
Thanks!

[brettw, 2012-03-09 21:57:22]

lgtm

http://codereview.chromium.org/9655019/diff/6006/ppapi/proxy/plugin_var_seria...
File ppapi/proxy/plugin_var_serialization_rules.h (right):

http://codereview.chromium.org/9655019/diff/6006/ppapi/proxy/plugin_var_seria...
ppapi/proxy/plugin_var_serialization_rules.h:39: // In most cases, |dispatcher_|
won't be NULL.
Can you make it clear here the you should check the validity of the weak pointer
before using it?

"In most cases, |dispatcher_| won't be NULL, but you should always check before
using it."

[yzshen1, 2012-03-09 22:05:48]

Thanks, Brett!

http://codereview.chromium.org/9655019/diff/6006/ppapi/proxy/plugin_var_seria...
File ppapi/proxy/plugin_var_serialization_rules.h (right):

http://codereview.chromium.org/9655019/diff/6006/ppapi/proxy/plugin_var_seria...
ppapi/proxy/plugin_var_serialization_rules.h:39: // In most cases, |dispatcher_|
won't be NULL.
On 2012/03/09 21:57:22, brettw wrote:
> Can you make it clear here the you should check the validity of the weak
pointer
> before using it?
> 
> "In most cases, |dispatcher_| won't be NULL, but you should always check
before
> using it."

Done.

[commit-bot: I haz the power, 2012-03-09 22:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/9655019/9001

[commit-bot: I haz the power, 2012-03-09 22:26:02]

Try job failure for 9655019-9001 (retry) on linux_clang for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-09 23:18:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/9655019/15006

[commit-bot: I haz the power, 2012-03-09 23:20:44]

Try job failure for 9655019-15006 on linux_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-10 03:30:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/9655019/12004

[commit-bot: I haz the power, 2012-03-10 06:51:50]

Change committed as 126014