Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Unified Diff: media/audio/audio_util.cc

Issue 9655018: Make AudioParameters a class instead of a struct (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_util.cc
diff --git a/media/audio/audio_util.cc b/media/audio/audio_util.cc
index b387ce71ed8175a402d5e4f7251bdc1d8df55882..13999d7828794a81af6124802af4c54accf59376 100644
--- a/media/audio/audio_util.cc
+++ b/media/audio/audio_util.cc
@@ -241,7 +241,7 @@ void InterleaveFloatToInt16(const std::vector<float*>& source,
}
}
-double GetAudioHardwareSampleRate() {
+int GetAudioHardwareSampleRate() {
#if defined(OS_MACOSX)
// Hardware sample-rate on the Mac can be configured, so we must query.
return AUAudioOutputStream::HardwareSampleRate();
@@ -249,7 +249,7 @@ double GetAudioHardwareSampleRate() {
if (!IsWASAPISupported()) {
// Fall back to Windows Wave implementation on Windows XP or lower
// and use 48kHz as default input sample rate.
- return 48000.0;
+ return 48000;
}
// Hardware sample-rate on Windows can be configured, so we must query.
@@ -259,22 +259,22 @@ double GetAudioHardwareSampleRate() {
#else
// Hardware for Linux is nearly always 48KHz.
// TODO(crogers) : return correct value in rare non-48KHz cases.
- return 48000.0;
+ return 48000;
#endif
}
-double GetAudioInputHardwareSampleRate(const std::string& device_id) {
+int GetAudioInputHardwareSampleRate(const std::string& device_id) {
// TODO(henrika): add support for device selection on all platforms.
// Only exists on Windows today.
#if defined(OS_MACOSX)
return AUAudioInputStream::HardwareSampleRate();
#elif defined(OS_WIN)
if (!IsWASAPISupported()) {
- return 48000.0;
+ return 48000;
}
return WASAPIAudioInputStream::HardwareSampleRate(device_id);
#else
- return 48000.0;
+ return 48000;
#endif
}
@@ -297,7 +297,7 @@ size_t GetAudioHardwareBufferSize() {
// This call must be done on a COM thread configured as MTA.
// TODO(tommi): http://code.google.com/p/chromium/issues/detail?id=103835.
int mixing_sample_rate =
- static_cast<int>(WASAPIAudioOutputStream::HardwareSampleRate(eConsole));
+ WASAPIAudioOutputStream::HardwareSampleRate(eConsole);
if (mixing_sample_rate == 48000)
return 480;
else if (mixing_sample_rate == 44100)
@@ -309,21 +309,21 @@ size_t GetAudioHardwareBufferSize() {
#endif
}
-uint32 GetAudioInputHardwareChannelCount(const std::string& device_id) {
+ChannelLayout GetAudioInputHardwareChannelLayout(const std::string& device_id) {
// TODO(henrika): add support for device selection on all platforms.
// Only exists on Windows today.
- enum channel_layout { MONO = 1, STEREO = 2 };
#if defined(OS_MACOSX)
- return MONO;
+ return CHANNEL_LAYOUT_MONO;
#elif defined(OS_WIN)
if (!IsWASAPISupported()) {
// Fall back to Windows Wave implementation on Windows XP or lower and
// use stereo by default.
- return STEREO;
+ return CHANNEL_LAYOUT_STEREO;
}
- return WASAPIAudioInputStream::HardwareChannelCount(device_id);
+ return WASAPIAudioInputStream::HardwareChannelCount(device_id) == 1 ?
+ CHANNEL_LAYOUT_MONO : CHANNEL_LAYOUT_STEREO;
#else
- return STEREO;
+ return CHANNEL_LAYOUT_STEREO;
#endif
}

Powered by Google App Engine
This is Rietveld 408576698