Implement prologue weak persistent handles.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 88 matching lines @@
   ref->set_raw(object);
   return reinterpret_cast<Dart_Handle>(ref);
 }
 
 RawObject* Api::UnwrapHandle(Dart_Handle object) {
 #ifdef DEBUG
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
-  ASSERT(state->IsValidWeakPersistentHandle(object) ||
+  ASSERT(state->IsValidPrologueWeakPersistentHandle(object) ||
+         state->IsValidWeakPersistentHandle(object) ||
          state->IsValidPersistentHandle(object) ||
          state->IsValidLocalHandle(object));
-  ASSERT(WeakPersistentHandle::raw_offset() == 0 &&
+  ASSERT(FinalizablePersistentHandle::raw_offset() == 0 &&
          PersistentHandle::raw_offset() == 0 &&
          LocalHandle::raw_offset() == 0);
 #endif
   return *(reinterpret_cast<RawObject**>(object));
 }
 
 #define DEFINE_UNWRAP(Type)                                                   \
   const Type& Api::Unwrap##Type##Handle(Dart_Handle dart_handle) {            \
     const Object& tmp = Object::Handle(Api::UnwrapHandle(dart_handle));       \
     Type& typed_handle = Type::Handle();                                      \
@@ skipping 13 matching lines @@
 }
 
 
 PersistentHandle* Api::UnwrapAsPersistentHandle(const ApiState& state,
                                                 Dart_Handle object) {
   ASSERT(state.IsValidPersistentHandle(object));
   return reinterpret_cast<PersistentHandle*>(object);
 }
 
 
-WeakPersistentHandle* Api::UnwrapAsWeakPersistentHandle(const ApiState& state,
-                                                        Dart_Handle object) {
+FinalizablePersistentHandle* Api::UnwrapAsWeakPersistentHandle(
+    const ApiState& state,
+    Dart_Handle object) {
   ASSERT(state.IsValidWeakPersistentHandle(object));
-  return reinterpret_cast<WeakPersistentHandle*>(object);
+  return reinterpret_cast<FinalizablePersistentHandle*>(object);
 }
 
 
+FinalizablePersistentHandle* Api::UnwrapAsPrologueWeakPersistentHandle(
+    const ApiState& state,
+    Dart_Handle object) {
+  ASSERT(state.IsValidPrologueWeakPersistentHandle(object));
+  return reinterpret_cast<FinalizablePersistentHandle*>(object);
+}
+
+
 Dart_Isolate Api::CastIsolate(Isolate* isolate) {
   return reinterpret_cast<Dart_Isolate>(isolate);
 }
 
 
 Dart_Handle Api::Success() {
   Isolate* isolate = Isolate::Current();
   ASSERT(isolate != NULL);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
@@ skipping 250 matching lines @@
 DART_EXPORT Dart_Handle Dart_NewWeakPersistentHandle(
     Dart_Handle object,
     void* peer,
     Dart_WeakPersistentHandleFinalizer callback) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
   DARTSCOPE_NOCHECKS(isolate);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   const Object& ref = Object::Handle(Api::UnwrapHandle(object));
-  WeakPersistentHandle* weak_ref =
+  FinalizablePersistentHandle* weak_ref =
       state->weak_persistent_handles().AllocateHandle();
   weak_ref->set_raw(ref);
   weak_ref->set_peer(peer);
   weak_ref->set_callback(callback);
   return reinterpret_cast<Dart_Handle>(weak_ref);
 }
 
 
+DART_EXPORT Dart_Handle Dart_NewPrologueWeakPersistentHandle(
+    Dart_Handle object,
+    void* peer,
+    Dart_WeakPersistentHandleFinalizer callback) {
+  Isolate* isolate = Isolate::Current();
+  CHECK_ISOLATE(isolate);
+  DARTSCOPE_NOCHECKS(isolate);
+  ApiState* state = isolate->api_state();
+  ASSERT(state != NULL);
+  const Object& ref = Object::Handle(Api::UnwrapHandle(object));
+  FinalizablePersistentHandle* prologue_weak_ref =
+      state->prologue_weak_persistent_handles().AllocateHandle();
+  prologue_weak_ref->set_raw(ref);
+  prologue_weak_ref->set_peer(peer);
+  prologue_weak_ref->set_callback(callback);
+  return reinterpret_cast<Dart_Handle>(prologue_weak_ref);

[siva, 2012/03/09 21:48:41]

This seems identical to Dart_NewWeakPersistentHandle maybe we could refactor
into a helper method that takes in weak_ref or prologue_weak_ref as a parameter.

[cshapiro, 2012/03/13 23:06:43]

Yes, it is pretty close.  I have factored out the allocation and initialization
into its own routine.

+}
+
+
 DART_EXPORT void Dart_DeletePersistentHandle(Dart_Handle object) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
+  if (state->IsValidPrologueWeakPersistentHandle(object)) {
+    FinalizablePersistentHandle* prologue_weak_ref =
+        Api::UnwrapAsPrologueWeakPersistentHandle(*state, object);
+    state->prologue_weak_persistent_handles().FreeHandle(prologue_weak_ref);
+    return;
+  }
   if (state->IsValidWeakPersistentHandle(object)) {
-    WeakPersistentHandle* weak_ref =
+    FinalizablePersistentHandle* weak_ref =
         Api::UnwrapAsWeakPersistentHandle(*state, object);
     state->weak_persistent_handles().FreeHandle(weak_ref);
-  } else {
-    PersistentHandle* ref = Api::UnwrapAsPersistentHandle(*state, object);
-    ASSERT(!state->IsProtectedHandle(ref));
-    if (!state->IsProtectedHandle(ref)) {
-      state->persistent_handles().FreeHandle(ref);
-    }
+    return;
+  }
+  PersistentHandle* ref = Api::UnwrapAsPersistentHandle(*state, object);
+  ASSERT(!state->IsProtectedHandle(ref));
+  if (!state->IsProtectedHandle(ref)) {
+    state->persistent_handles().FreeHandle(ref);
   }
 }
 
 
 DART_EXPORT bool Dart_IsWeakPersistentHandle(Dart_Handle object) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   return state->IsValidWeakPersistentHandle(object);
 }
 
 
+DART_EXPORT bool Dart_IsPrologueWeakPersistentHandle(Dart_Handle object) {
+  Isolate* isolate = Isolate::Current();
+  CHECK_ISOLATE(isolate);
+  ApiState* state = isolate->api_state();
+  ASSERT(state != NULL);
+  return state->IsValidPrologueWeakPersistentHandle(object);
+}
+
+
 DART_EXPORT Dart_Handle Dart_NewWeakReferenceSet(Dart_Handle* keys,
                                                  intptr_t num_keys,
                                                  Dart_Handle* values,
                                                  intptr_t num_values) {
   Isolate* isolate = Isolate::Current();
   CHECK_ISOLATE(isolate);
   ApiState* state = isolate->api_state();
   ASSERT(state != NULL);
   if (keys == NULL) {
     return Api::NewError("%s expects argument 'keys' to be non-null.",
@@ skipping 2616 matching lines @@
       *buffer = NULL;
     }
     delete debug_region;
   } else {
     *buffer = NULL;
     *buffer_size = 0;
   }
 }
 
 }  // namespace dart