Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 9654001: Fix pkgconfig wrapper for 64 bits (Closed)

Created:
8 years, 9 months ago by piman
Modified:
8 years, 9 months ago
Reviewers:
wtc, sadrul
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix pkgconfig wrapper for 64 bits BUG=none TEST=build 64-bit version of chrome using 64-bit chromeos sysroot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M build/linux/pkg-config-wrapper View 1 chunk +14 lines, -4 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/nss/ssl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libpng/libpng.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
piman
sadrul: please review. Sorry to send this to you, but you're the only one who's ...
8 years, 9 months ago (2012-03-08 23:04:13 UTC) #1
sadrul
LGTM
8 years, 9 months ago (2012-03-09 03:22:17 UTC) #2
wtc
LGTM. I guess these files aren't subject to the 80-char line length requirement.
8 years, 9 months ago (2012-03-09 20:31:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/9654001/1
8 years, 9 months ago (2012-03-09 20:48:42 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-09 22:52:19 UTC) #5
Change committed as 125925

Powered by Google App Engine
This is Rietveld 408576698