Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 9652017: [chromeos] Fix chrome://cryptohome crash (Closed)

Created:
8 years, 9 months ago by gauravsh
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/git/chromium/src@master
Visibility:
Public.

Description

[chromeos] Fix chrome://cryptohome crash Check readiness of the token before requesting info on it, otherwise this triggers a CHECK in GetTPMTokenInfo. BUG=chromium-os:27499 TEST=navigate to chrome://cryptohome when token is not initialized. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
gauravsh-google
stevenjb/gspencer: review jhawkins: owners approval
8 years, 9 months ago (2012-03-08 23:33:06 UTC) #1
Greg Spencer (Chromium)
LGTM
8 years, 9 months ago (2012-03-08 23:37:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/9652017/1
8 years, 9 months ago (2012-03-08 23:43:45 UTC) #3
commit-bot: I haz the power
Presubmit check for 9652017-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-08 23:43:48 UTC) #4
James Hawkins
LGTM
8 years, 9 months ago (2012-03-09 00:13:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/9652017/1
8 years, 9 months ago (2012-03-09 00:23:53 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-09 03:12:53 UTC) #7
Change committed as 125783

Powered by Google App Engine
This is Rietveld 408576698