Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9652005: base: Add more BASE_EXPORT macros (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

base: Add more BASE_EXPORT macros BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M base/mac/foundation_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/string16.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
These are currently the last BASE_EXPORTs needed to build target 'chrome'.
8 years, 9 months ago (2012-03-08 19:24:52 UTC) #1
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-08 19:31:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9652005/1
8 years, 9 months ago (2012-03-08 19:35:22 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-08 22:55:19 UTC) #4 
Change committed as 125704

Powered by Google App Engine
This is Rietveld 408576698