Pass content-type resources to web intents. Goes through download, then invokes the p…

content/browser/intents/internal_web_intents_dispatcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/intents/internal_web_intents_dispatcher.h"
 
 #include "content/browser/intents/intent_injector.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_delegate.h"
 #include "webkit/glue/web_intent_data.h"
 #include "webkit/glue/web_intent_reply_data.h"
 
 using content::WebContents;
 
 InternalWebIntentsDispatcher::InternalWebIntentsDispatcher(
     const webkit_glue::WebIntentData& intent)
     : intent_(intent),
       intent_injector_(NULL) {}
 
@@ skipping 32 matching lines @@
   if (!reply_callback_.is_null())
     reply_callback_.Run(reply_type, data);
 
   delete this;
 }
 
 void InternalWebIntentsDispatcher::RegisterReplyNotification(
     const content::WebIntentsDispatcher::ReplyNotification& closure) {
   reply_notifiers_.push_back(closure);
 }
+
+namespace content {
+
+content::WebIntentsDispatcher* WebIntentsDispatcher::Create(

[jam, 2012/03/29 17:59:19]

nit: by convention we put this in the to of the file. also, since this is
defined in web_intents_dispatcher.h, by convention we put the static function in
web_intents_dispatcher_impl.cc

[Greg Billock, 2012/03/29 18:45:08]

I can't put an impl file in the public/browser dir, since it can't refer to the
browser/intents dep. Shall I make a new file alongside this one? Or just keep
the impl in this file at the top?

On 2012/03/29 17:59:19, John Abd-El-Malek wrote:

[jam, 2012/03/30 16:09:44]

I meant in the impl file in content\browser, i.e.
content\browser\intents\web_intents_dispatcher_impl.cc

[jam, 2012/04/02 15:05:08]

ping?

[Greg Billock, 2012/04/02 16:15:03]

Done.

+    const webkit_glue::WebIntentData& data) {
+  return new InternalWebIntentsDispatcher(data);
+}
+
+}  // namespace content