Pass content-type resources to web intents. Goes through download, then invokes the p…

content/public/browser/web_intents_dispatcher.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_INTENTS_DISPATCHER_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_INTENTS_DISPATCHER_H_
 
 #include "base/callback.h"
 #include "content/common/content_export.h"
 #include "webkit/glue/web_intent_reply_data.h"
 
 namespace webkit_glue {
 enum WebIntentReplyType;
 struct WebIntentData;
 }
 
 namespace content {
 
 class WebContents;
+class WebContentsDelegate;
 
 // This class is the coordinator for dispatching web intents and seeing that
 // return messages are sent to the correct invoking context. The WebContents
 // for the invoking context will create one of these for each intent and hand
 // a pointer to the client WebContentsDelegate code. The WebContentsDelegate
 // code can then read the intent data, create UI to pick the service, and
 // create a new context for that service.
 //
 // At that point, it should call DispatchIntent, which will deliver the intent
 // to the new context. If anything goes wrong during setup, the client
@@ skipping 22 matching lines @@
   // the intent. Deletes the object; it should not be used after this call
   // returns. Calls the reply notifications, if any are registered.
   virtual void SendReplyMessage(webkit_glue::WebIntentReplyType reply_type,
                                 const string16& data) = 0;
 
   // Register a callback to be notified when SendReplyMessage is called.
   // Multiple callbacks may be registered.
   virtual void RegisterReplyNotification(const ReplyNotification& closure) = 0;
 };
 
+// Create and dispatch an internal (embedder-triggered) intent. This will create
+// a new dispatcher with the passed intent payload |data| and dispatch it to the
+// delegate of the provided WebContents |target|.
+CONTENT_EXPORT void DispatchInternalIntent(

[jam, 2012/03/29 02:33:51]

perhaps this should be a static Create inside WebIntensDispatcher?  i.e.

static WebIntensDispatcher* Create(const webkit_glue::WebIntentData& data);

then whoever calls this can call WebIntentDispatch themselves.

i say this because this is really a creator function, and this is the pattern we
use in the rest of the content api

[Greg Billock, 2012/03/29 17:33:03]

Sounds good. I was trying to keep dispatching within content, but it really is a
one-liner.

On 2012/03/29 02:33:51, John Abd-El-Malek wrote:

+    const webkit_glue::WebIntentData& data,
+    WebContents* target);
+
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_INTENTS_DISPATCHER_H_