Pass content-type resources to web intents. Goes through download, then invokes the p…

chrome/browser/download/chrome_download_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 190 matching lines @@
         base::Bind(
             &ChromeDownloadManagerDelegate::CheckClientDownloadDone,
             this,
             item->GetId()));
     return false;
   }
 #endif
   return true;
 }
 
+bool ChromeDownloadManagerDelegate::ShouldOpenWithWebIntent(
+    DownloadItem* item) {
+  std::string mime_type = item->GetMimeType();
+  LOG(INFO) << "Testing " << mime_type << " for web intents";
+
+  // TODO: Check for explicit user-caused download?
+
+  if (mime_type == "application/rss+xml" ||

[jam, 2012/03/16 21:36:26]

why is this stuff in chrome?

[Greg Billock, 2012/03/18 00:32:21]

This method is basically a policy delegation to the embedder. The content layer
says "hey, do you want me to dispatch this download I just did by issuing a web
intent?" I think it's possible that different embedders would have different
answers to that question. Specifically, maintaining a whitelist of this kind, or
deriving it from a list of installed apps, seems like something that should be
done chrome-side.

+      mime_type == "application/atom+xml" ||
+      mime_type == "application/ms-word" ||
+      mime_type == "application/pdf") {
+    return true;
+  }
+
+  return false;
+}
+
 bool ChromeDownloadManagerDelegate::ShouldOpenDownload(DownloadItem* item) {
   if (!IsExtensionDownload(item)) {
     return true;
   }
 
   scoped_refptr<CrxInstaller> crx_installer =
       download_crx_util::OpenChromeExtension(profile_, *item);
 
   // CRX_INSTALLER_DONE will fire when the install completes.  Observe()
   // will call DelayedDownloadOpened() on this item.  If this DownloadItem is
@@ skipping 384 matching lines @@
     int32 download_id, int64 db_handle) {
   // It's not immediately obvious, but HistoryBackend::CreateDownload() can
   // call this function with an invalid |db_handle|. For instance, this can
   // happen when the history database is offline. We cannot have multiple
   // DownloadItems with the same invalid db_handle, so we need to assign a
   // unique |db_handle| here.
   if (db_handle == DownloadItem::kUninitializedHandle)
     db_handle = download_history_->GetNextFakeDbHandle();
   download_manager_->OnItemAddedToPersistentStore(download_id, db_handle);
 }