OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
284 # TODO(thestig) temporarily disabled, doesn't work in third_party/ | 284 # TODO(thestig) temporarily disabled, doesn't work in third_party/ |
285 #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories( | 285 #results.extend(input_api.canned_checks.CheckSvnModifiedDirectories( |
286 # input_api, output_api, sources)) | 286 # input_api, output_api, sources)) |
287 # Make sure the tree is 'open'. | 287 # Make sure the tree is 'open'. |
288 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 288 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
289 input_api, | 289 input_api, |
290 output_api, | 290 output_api, |
291 json_url='http://chromium-status.appspot.com/current?format=json')) | 291 json_url='http://chromium-status.appspot.com/current?format=json')) |
292 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, | 292 results.extend(input_api.canned_checks.CheckRietveldTryJobExecution(input_api, |
293 output_api, 'http://codereview.chromium.org', | 293 output_api, 'http://codereview.chromium.org', |
294 ('win_rel', 'linux_rel', 'mac_rel'), 'tryserver@chromium.org')) | 294 ('win_rel', 'linux_rel', 'mac_rel, win:compile'), |
| 295 'tryserver@chromium.org')) |
295 | 296 |
296 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 297 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
297 input_api, output_api)) | 298 input_api, output_api)) |
298 results.extend(input_api.canned_checks.CheckChangeHasTestField( | 299 results.extend(input_api.canned_checks.CheckChangeHasTestField( |
299 input_api, output_api)) | 300 input_api, output_api)) |
300 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 301 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
301 input_api, output_api)) | 302 input_api, output_api)) |
302 results.extend(_CheckSubversionConfig(input_api, output_api)) | 303 results.extend(_CheckSubversionConfig(input_api, output_api)) |
303 return results | 304 return results |
304 | 305 |
(...skipping 24 matching lines...) Expand all Loading... |
329 for non_android_re in (aura_re, win_re): | 330 for non_android_re in (aura_re, win_re): |
330 if all(re.search(non_android_re, f) for f in affected_files): | 331 if all(re.search(non_android_re, f) for f in affected_files): |
331 possibly_android = False | 332 possibly_android = False |
332 break | 333 break |
333 if possibly_android: | 334 if possibly_android: |
334 for f in change.AffectedFiles(): | 335 for f in change.AffectedFiles(): |
335 if any(re.search(r, f.LocalPath()) for r in android_re_list): | 336 if any(re.search(r, f.LocalPath()) for r in android_re_list): |
336 preferred.append('android') | 337 preferred.append('android') |
337 break | 338 break |
338 return preferred | 339 return preferred |
OLD | NEW |