Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm

Issue 9649020: [Web Intents] WebIntentPickerModel uses URL instead of index to reference registered services. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mac fix Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm ('k') | chrome/browser/ui/gtk/web_intent_picker_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm b/chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm
index 4dc72cfbf4d2aa4457245932bf82bf42469d2e57..e0478294b92459e5c7919e4ac96a6b33bb2111e7 100644
--- a/chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm
@@ -21,7 +21,7 @@ class MockIntentPickerDelegate : public WebIntentPickerDelegate {
public:
virtual ~MockIntentPickerDelegate() {}
- MOCK_METHOD2(OnServiceChosen, void(size_t index, Disposition disposition));
+ MOCK_METHOD2(OnServiceChosen, void(const GURL& url, Disposition disposition));
MOCK_METHOD1(OnInlineDispositionWebContentsCreated,
void(content::WebContents* web_contents));
MOCK_METHOD0(OnCancelled, void());
@@ -167,11 +167,12 @@ TEST_F(WebIntentPickerSheetControllerTest, CloseWillClose) {
TEST_F(WebIntentPickerSheetControllerTest, DontCancelAfterServiceInvokation) {
CreateBubble();
- model_.AddInstalledService(string16(), GURL(),
+ GURL url;
+ model_.AddInstalledService(string16(), url,
WebIntentPickerModel::DISPOSITION_WINDOW);
EXPECT_CALL(delegate_, OnServiceChosen(
- 0, WebIntentPickerModel::DISPOSITION_WINDOW));
+ url, WebIntentPickerModel::DISPOSITION_WINDOW));
EXPECT_CALL(delegate_, OnCancelled()).Times(0);
EXPECT_CALL(delegate_, OnClosing());
« no previous file with comments | « chrome/browser/ui/cocoa/web_intent_picker_cocoa.mm ('k') | chrome/browser/ui/gtk/web_intent_picker_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698