Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 9649016: ninja: make cross-compilation use $CC/$CXX for the target compiler (Closed)

Created:
8 years, 9 months ago by piman
Modified:
8 years, 3 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja: make cross-compilation use $CC/$CXX for the target compiler BUG=None TEST=set CC/CXX to cross-compiler, set GYP_CROSSCOMPILE to 1, run gyp, ninja chrome.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M pylib/gyp/generator/ninja.py View 4 chunks +29 lines, -14 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
piman
8 years, 9 months ago (2012-03-09 02:06:55 UTC) #1
Ami GONE FROM CHROMIUM
LGTM assuming it works :) (I haven't patched & tried; let me know if you ...
8 years, 9 months ago (2012-03-09 17:36:45 UTC) #2
Ami GONE FROM CHROMIUM
Yaron: can you confirm this doesn't break your cross-compile setup?
8 years, 7 months ago (2012-05-10 03:38:25 UTC) #3
Yaron
As is, I think it'll break our setup. See android_gyp in: http://code.google.com/p/chromium/source/search?q=envsetup.sh&origq=envsetup.sh&btnG=Search+Trunk where we only ...
8 years, 7 months ago (2012-05-10 19:08:50 UTC) #4
Ami GONE FROM CHROMIUM
On 2012/05/10 19:08:50, Yaron wrote: > As is, I think it'll break our setup. See ...
8 years, 7 months ago (2012-05-10 19:12:41 UTC) #5
Yaron
On 2012/05/10 19:12:41, Ami Fischman wrote: > On 2012/05/10 19:08:50, Yaron wrote: > > As ...
8 years, 7 months ago (2012-05-10 20:40:39 UTC) #6
michaelbai
Can this be committed? I have a change depend on this.
8 years, 5 months ago (2012-07-26 00:43:20 UTC) #7
Nico
How does this relate to https://chromiumcodereview.appspot.com/10833021/ ?
8 years, 4 months ago (2012-08-01 18:19:54 UTC) #8
Nico
http://codereview.chromium.org/9649016/diff/1/pylib/gyp/generator/ninja.py File pylib/gyp/generator/ninja.py (right): http://codereview.chromium.org/9649016/diff/1/pylib/gyp/generator/ninja.py#newcode1069 pylib/gyp/generator/ninja.py:1069: cc_host, cxx_host = cc, cxx The mac bots set ...
8 years, 4 months ago (2012-08-03 04:41:34 UTC) #9
Ami GONE FROM CHROMIUM
8 years, 4 months ago (2012-08-11 17:23:03 UTC) #10
Time to close this in favor of http://code.google.com/p/gyp/source/detail?r=1463
?

Powered by Google App Engine
This is Rietveld 408576698