Issue 9646029: Add an explicit dependency from glue to WebKit/chromium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9646029: Add an explicit dependency from glue to WebKit/chromium (Closed)

Created:
8 years, 9 months ago by Nico

Modified:
8 years, 9 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add an explicit dependency from glue to WebKit/chromium BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126181

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	webkit/glue/webkit_glue.gypi	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

glue heavily uses the chromium webkit api, which means this is required for the mac ...

8 years, 9 months ago (2012-03-09 05:31:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9646029/2001

8 years, 9 months ago (2012-03-12 16:32:14 UTC) #3

Dirk Pranke

8 years, 9 months ago (2012-03-12 20:09:07 UTC) #5

On 2012/03/09 05:31:32, Nico wrote:
> glue heavily uses the chromium webkit api, which means this is required for
the
> mac components build. I'm not sure why it's not needed for linux.

Linux never complains about missing dependencies when building shared libraries,
only executables. 

Windows declared the dependency on line 533; you could/should probably delete
that line now.

Expand Messages | Collapse Messages