Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: ppapi/tests/testing_instance.cc

Issue 9646027: Switch PPAPITests to run in browser_tests instead of ui_tests. The former is sharded and so tests r… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix race condition where we might miss the first notification Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/testing_instance.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/tests/testing_instance.cc
===================================================================
--- ppapi/tests/testing_instance.cc (revision 126008)
+++ ppapi/tests/testing_instance.cc (working copy)
@@ -29,7 +29,6 @@
: pp::InstancePrivate(instance),
#endif
current_case_(NULL),
- progress_cookie_number_(0),
executed_tests_(false),
nacl_mode_(false) {
callback_factory_.Initialize(this);
@@ -233,10 +232,10 @@
void TestingInstance::ReportProgress(const std::string& progress_value) {
// Use streams since nacl doesn't compile base yet (for StringPrintf).
- std::ostringstream cookie_name;
- cookie_name << "PPAPI_PROGRESS_" << progress_cookie_number_;
- SetCookie(cookie_name.str(), progress_value);
- progress_cookie_number_++;
+ std::ostringstream script;
+ script << "window.domAutomationController.setAutomationId(0);" <<
+ "window.domAutomationController.send(\"" << progress_value << "\")";
+ EvalScript(script.str());
}
class Module : public pp::Module {
« no previous file with comments | « ppapi/tests/testing_instance.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698