Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3270)

Unified Diff: chrome/chrome_tests.gypi

Issue 9646027: Switch PPAPITests to run in browser_tests instead of ui_tests. The former is sharded and so tests r… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: move gyp rules to browser_tests Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_tests.gypi
===================================================================
--- chrome/chrome_tests.gypi (revision 125849)
+++ chrome/chrome_tests.gypi (working copy)
@@ -773,24 +773,6 @@
{
'target_name': 'ui_tests',
'type': 'executable',
- 'copies': [
- {
- 'destination': '<(PRODUCT_DIR)',
- 'files': [
- # Keep 'test_case.html.mock-http-headers' with 'test_case.html'.
- '../ppapi/tests/test_case.html',
- '../ppapi/tests/test_case.html.mock-http-headers',
- '../ppapi/tests/test_page.css',
- '../ppapi/native_client/tests/ppapi_tests/test_case.nmf',
- ],
- },
- {
- 'destination': '<(PRODUCT_DIR)/test_url_loader_data',
- 'files': [
- '../ppapi/tests/test_url_loader_data/hello.txt',
- ],
- },
- ],
'dependencies': [
'browser',
'chrome',
@@ -809,7 +791,6 @@
'../third_party/icu/icu.gyp:icuuc',
'../third_party/libxml/libxml.gyp:libxml',
# run time dependencies
- '../ppapi/ppapi_internal.gyp:ppapi_tests',
'../third_party/mesa/mesa.gyp:osmesa',
'../webkit/webkit.gyp:pull_in_copy_TestNetscapePlugIn',
],
@@ -864,7 +845,6 @@
'test/ui/layout_plugin_uitest.cc',
'test/ui/named_interface_uitest.cc',
'test/ui/npapi_uitest.cc',
- 'test/ui/ppapi_uitest.cc',
'test/ui/sandbox_uitests.cc',
'../content/browser/appcache/appcache_ui_test.cc',
'../content/browser/in_process_webkit/dom_storage_uitest.cc',
@@ -873,11 +853,6 @@
'../content/worker/test/worker_uitest.cc',
],
'conditions': [
- ['disable_nacl==0 and disable_nacl_untrusted==0', {
- 'dependencies': [
- '../ppapi/ppapi_untrusted.gyp:ppapi_nacl_tests',
- ],
- }],
['target_arch!="arm"', {
'dependencies': [
'../webkit/webkit.gyp:copy_npapi_test_plugin',
@@ -2520,6 +2495,24 @@
'type': 'executable',
'msvs_cygwin_shell': 0,
'msvs_cygwin_dirs': ['<(DEPTH)/third_party/cygwin'],
+ 'copies': [
+ {
+ 'destination': '<(PRODUCT_DIR)',
+ 'files': [
+ # Keep 'test_case.html.mock-http-headers' with 'test_case.html'.
+ '../ppapi/tests/test_case.html',
+ '../ppapi/tests/test_case.html.mock-http-headers',
+ '../ppapi/tests/test_page.css',
+ '../ppapi/native_client/tests/ppapi_tests/test_case.nmf',
+ ],
+ },
+ {
+ 'destination': '<(PRODUCT_DIR)/test_url_loader_data',
+ 'files': [
+ '../ppapi/tests/test_url_loader_data/hello.txt',
+ ],
+ },
+ ],
'dependencies': [
'browser',
'browser/sync/protocol/sync_proto.gyp:sync_proto',
@@ -2544,6 +2537,7 @@
'../v8/tools/gyp/v8.gyp:v8',
'../webkit/webkit.gyp:test_shell_test_support',
# Runtime dependencies
+ '../ppapi/ppapi_internal.gyp:ppapi_tests',
'../third_party/mesa/mesa.gyp:osmesa',
'../webkit/webkit.gyp:pull_in_copy_TestNetscapePlugIn',
],
@@ -2890,6 +2884,7 @@
'test/data/webui/print_preview.cc',
'test/data/webui/print_preview.js',
'test/gpu/gpu_feature_browsertest.cc',
+ 'test/ui/ppapi_uitest.cc',
# TODO(craig): Rename this and run from base_unittests when the test
# is safe to run there. See http://crbug.com/78722 for details.
'../base/files/file_path_watcher_browsertest.cc',
@@ -2950,10 +2945,17 @@
},
],
'conditions': [
- ['disable_nacl!=1', {
+ ['disable_nacl==0', {
'sources':[
'browser/extensions/extension_nacl_browsertest.cc',
],
+ 'conditions': [
+ ['disable_nacl_untrusted==0', {
+ 'dependencies': [
+ '../ppapi/ppapi_untrusted.gyp:ppapi_nacl_tests',
+ ],
+ }],
+ ],
}],
['chromeos==0', {
'sources/': [

Powered by Google App Engine
This is Rietveld 408576698