Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: frog/leg/typechecker.dart

Issue 9642001: Make string juxtaposition combine properly with string interpolations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove last bugs and clean up builder. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« frog/leg/ssa/nodes.dart ('K') | « frog/leg/tree/visitors.dart ('k') | frog/tests/leg_only/src/LiteralStringJuxtapositionTest.dart » ('j') | tests/language/language-leg.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/typechecker.dart
diff --git a/frog/leg/typechecker.dart b/frog/leg/typechecker.dart
index 5a81a859ebc203d273684f167f091930ab890ff2..cf33b9e611ac8f90c677ea5789102328fd4d3b26 100644
--- a/frog/leg/typechecker.dart
+++ b/frog/leg/typechecker.dart
@@ -491,7 +491,9 @@ class TypeCheckerVisitor implements Visitor<Type> {
return stringType;
}
- Type visitLiteralStringJuxtaposition(LiteralStringJuxtaposition node) {
+ Type visitStringJuxtaposition(StringJuxtaposition node) {
+ analyze(node.first);
+ analyze(node.second);
return stringType;
}
« frog/leg/ssa/nodes.dart ('K') | « frog/leg/tree/visitors.dart ('k') | frog/tests/leg_only/src/LiteralStringJuxtapositionTest.dart » ('j') | tests/language/language-leg.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698