Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/mjsunit/math-floor-of-div.js

Issue 9638018: [v8-dev] Optimise Math.floor(x/y) to use integer division for specific divisor.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/ia32/lithium-ia32.h ('K') | « src/x64/lithium-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/math-floor-of-div.js
===================================================================
--- test/mjsunit/math-floor-of-div.js (revision 0)
+++ test/mjsunit/math-floor-of-div.js (revision 0)
@@ -0,0 +1,128 @@
+// Copyright 2011 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+// * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+// * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following
+// disclaimer in the documentation and/or other materials provided
+// with the distribution.
+// * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived
+// from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --allow-natives-syntax --nouse_inlining
+
+// Use this function as reference. Make sure it is not inlined.
+function div(a, b) {
+ return a / b;
+}
+
+var limit = 0x1000000;
+var exhaustive_limit = 100;
+var step = 10;
+var values = [0x10000001,
+ 0x12345678,
+ -0x789abcdf, // 0x87654321
+ 0x01234567,
+ 0x76543210,
+ -0x80000000, // 0x80000000
+ 0x7fffffff,
+ -0x0fffffff, // 0xf0000001
+ 0x00000010,
+ -0x01000000 // 0xff000000
+ ];
+
+function test_div() {
+ var c = 0;
+ for (var l = 0; l <= limit; l++) {
fschneider 2012/03/28 09:59:18 Maybe use a different letter (j, k?), since 1 and
Alexandre 2012/03/28 16:27:38 Done.
+ if (l > exhaustive_limit) { c += step; l += c; }
+ assertEquals(Math.floor(div(l, 1)), Math.floor(l / 1)); assertEquals(Math.floor(div(l, -1)), Math.floor(l / -1));
fschneider 2012/03/28 09:59:18 Please break the line at 80 chars.
Alexandre 2012/03/28 16:27:38 Done.
+ assertEquals(Math.floor(div(l, 2)), Math.floor(l / 2)); assertEquals(Math.floor(div(l, -2)), Math.floor(l / -2));
+ assertEquals(Math.floor(div(l, 3)), Math.floor(l / 3)); assertEquals(Math.floor(div(l, -3)), Math.floor(l / -3));
+ assertEquals(Math.floor(div(l, 4)), Math.floor(l / 4)); assertEquals(Math.floor(div(l, -4)), Math.floor(l / -4));
+ assertEquals(Math.floor(div(l, 5)), Math.floor(l / 5)); assertEquals(Math.floor(div(l, -5)), Math.floor(l / -5));
+ assertEquals(Math.floor(div(l, 6)), Math.floor(l / 6)); assertEquals(Math.floor(div(l, -6)), Math.floor(l / -6));
+ assertEquals(Math.floor(div(l, 7)), Math.floor(l / 7)); assertEquals(Math.floor(div(l, -7)), Math.floor(l / -7));
+ assertEquals(Math.floor(div(l, 8)), Math.floor(l / 8)); assertEquals(Math.floor(div(l, -8)), Math.floor(l / -8));
+ assertEquals(Math.floor(div(l, 9)), Math.floor(l / 9)); assertEquals(Math.floor(div(l, -9)), Math.floor(l / -9));
+ assertEquals(Math.floor(div(l, 10)), Math.floor(l / 10)); assertEquals(Math.floor(div(l, -10)), Math.floor(l / -10));
+ assertEquals(Math.floor(div(l, 11)), Math.floor(l / 11)); assertEquals(Math.floor(div(l, -11)), Math.floor(l / -11));
+ assertEquals(Math.floor(div(l, 12)), Math.floor(l / 12)); assertEquals(Math.floor(div(l, -12)), Math.floor(l / -12));
+ assertEquals(Math.floor(div(l, 13)), Math.floor(l / 13)); assertEquals(Math.floor(div(l, -13)), Math.floor(l / -13));
+ assertEquals(Math.floor(div(l, 14)), Math.floor(l / 14)); assertEquals(Math.floor(div(l, -14)), Math.floor(l / -14));
+ assertEquals(Math.floor(div(l, 15)), Math.floor(l / 15)); assertEquals(Math.floor(div(l, -15)), Math.floor(l / -15));
+ assertEquals(Math.floor(div(l, 16)), Math.floor(l / 16)); assertEquals(Math.floor(div(l, -16)), Math.floor(l / -16));
+ assertEquals(Math.floor(div(l, 17)), Math.floor(l / 17)); assertEquals(Math.floor(div(l, -17)), Math.floor(l / -17));
+ assertEquals(Math.floor(div(l, 18)), Math.floor(l / 18)); assertEquals(Math.floor(div(l, -18)), Math.floor(l / -18));
+ assertEquals(Math.floor(div(l, 19)), Math.floor(l / 19)); assertEquals(Math.floor(div(l, -19)), Math.floor(l / -19));
+ assertEquals(Math.floor(div(l, 20)), Math.floor(l / 20)); assertEquals(Math.floor(div(l, -20)), Math.floor(l / -20));
+ assertEquals(Math.floor(div(l, 21)), Math.floor(l / 21)); assertEquals(Math.floor(div(l, -21)), Math.floor(l / -21));
+ assertEquals(Math.floor(div(l, 22)), Math.floor(l / 22)); assertEquals(Math.floor(div(l, -22)), Math.floor(l / -22));
+ assertEquals(Math.floor(div(l, 23)), Math.floor(l / 23)); assertEquals(Math.floor(div(l, -23)), Math.floor(l / -23));
+ assertEquals(Math.floor(div(l, 24)), Math.floor(l / 24)); assertEquals(Math.floor(div(l, -24)), Math.floor(l / -24));
+ assertEquals(Math.floor(div(l, 25)), Math.floor(l / 25)); assertEquals(Math.floor(div(l, -25)), Math.floor(l / -25));
+ assertEquals(Math.floor(div(l, 125)), Math.floor(l / 125)); assertEquals(Math.floor(div(l, -125)), Math.floor(l / -125));
+ assertEquals(Math.floor(div(l, 625)), Math.floor(l / 625)); assertEquals(Math.floor(div(l, -625)), Math.floor(l / -625));
+ }
+ c = 0;
+ for (var l = 0; l <= limit; l++) {
+ if (l > exhaustive_limit) { c += step; l += c; }
+ assertEquals(Math.floor(div(-l, 1)), Math.floor(-l / 1)); assertEquals(Math.floor(div(-l, -1)), Math.floor(-l / -1));
+ assertEquals(Math.floor(div(-l, 2)), Math.floor(-l / 2)); assertEquals(Math.floor(div(-l, -2)), Math.floor(-l / -2));
+ assertEquals(Math.floor(div(-l, 3)), Math.floor(-l / 3)); assertEquals(Math.floor(div(-l, -3)), Math.floor(-l / -3));
+ assertEquals(Math.floor(div(-l, 4)), Math.floor(-l / 4)); assertEquals(Math.floor(div(-l, -4)), Math.floor(-l / -4));
+ assertEquals(Math.floor(div(-l, 5)), Math.floor(-l / 5)); assertEquals(Math.floor(div(-l, -5)), Math.floor(-l / -5));
+ assertEquals(Math.floor(div(-l, 6)), Math.floor(-l / 6)); assertEquals(Math.floor(div(-l, -6)), Math.floor(-l / -6));
+ assertEquals(Math.floor(div(-l, 7)), Math.floor(-l / 7)); assertEquals(Math.floor(div(-l, -7)), Math.floor(-l / -7));
+ assertEquals(Math.floor(div(-l, 8)), Math.floor(-l / 8)); assertEquals(Math.floor(div(-l, -8)), Math.floor(-l / -8));
+ assertEquals(Math.floor(div(-l, 9)), Math.floor(-l / 9)); assertEquals(Math.floor(div(-l, -9)), Math.floor(-l / -9));
+ assertEquals(Math.floor(div(-l, 10)), Math.floor(-l / 10)); assertEquals(Math.floor(div(-l, -10)), Math.floor(-l / -10));
+ assertEquals(Math.floor(div(-l, 11)), Math.floor(-l / 11)); assertEquals(Math.floor(div(-l, -11)), Math.floor(-l / -11));
+ assertEquals(Math.floor(div(-l, 12)), Math.floor(-l / 12)); assertEquals(Math.floor(div(-l, -12)), Math.floor(-l / -12));
+ assertEquals(Math.floor(div(-l, 13)), Math.floor(-l / 13)); assertEquals(Math.floor(div(-l, -13)), Math.floor(-l / -13));
+ assertEquals(Math.floor(div(-l, 14)), Math.floor(-l / 14)); assertEquals(Math.floor(div(-l, -14)), Math.floor(-l / -14));
+ assertEquals(Math.floor(div(-l, 15)), Math.floor(-l / 15)); assertEquals(Math.floor(div(-l, -15)), Math.floor(-l / -15));
+ assertEquals(Math.floor(div(-l, 16)), Math.floor(-l / 16)); assertEquals(Math.floor(div(-l, -16)), Math.floor(-l / -16));
+ assertEquals(Math.floor(div(-l, 17)), Math.floor(-l / 17)); assertEquals(Math.floor(div(-l, -17)), Math.floor(-l / -17));
+ assertEquals(Math.floor(div(-l, 18)), Math.floor(-l / 18)); assertEquals(Math.floor(div(-l, -18)), Math.floor(-l / -18));
+ assertEquals(Math.floor(div(-l, 19)), Math.floor(-l / 19)); assertEquals(Math.floor(div(-l, -19)), Math.floor(-l / -19));
+ assertEquals(Math.floor(div(-l, 20)), Math.floor(-l / 20)); assertEquals(Math.floor(div(-l, -20)), Math.floor(-l / -20));
+ assertEquals(Math.floor(div(-l, 21)), Math.floor(-l / 21)); assertEquals(Math.floor(div(-l, -21)), Math.floor(-l / -21));
+ assertEquals(Math.floor(div(-l, 22)), Math.floor(-l / 22)); assertEquals(Math.floor(div(-l, -22)), Math.floor(-l / -22));
+ assertEquals(Math.floor(div(-l, 23)), Math.floor(-l / 23)); assertEquals(Math.floor(div(-l, -23)), Math.floor(-l / -23));
+ assertEquals(Math.floor(div(-l, 24)), Math.floor(-l / 24)); assertEquals(Math.floor(div(-l, -24)), Math.floor(-l / -24));
+ assertEquals(Math.floor(div(-l, 25)), Math.floor(-l / 25)); assertEquals(Math.floor(div(-l, -25)), Math.floor(-l / -25));
+ assertEquals(Math.floor(div(-l, 125)), Math.floor(-l / 125)); assertEquals(Math.floor(div(-l, -125)), Math.floor(-l / -125));
+ assertEquals(Math.floor(div(-l, 625)), Math.floor(-l / 625)); assertEquals(Math.floor(div(-l, -625)), Math.floor(-l / -625));
+ }
+ // Test for edge cases.
+ // Use (values[key] + 0) to force the integer type.
+ // (values[key] | 0) does not work anymore as it is optimized by hydrogen.)
+ for (var i = 0; i < values.length; i++) {
+ for (var j = 0; j < values.length; j++) {
+ assertEquals(Math.floor(div((values[i] + 0), (values[j] + 0))), Math.floor((values[i] + 0) / (values[j] + 0)));
+ assertEquals(Math.floor(div(-(values[i] + 0), (values[j] + 0))), Math.floor(-(values[i] + 0) / (values[j] + 0)));
+ assertEquals(Math.floor(div((values[i] + 0), -(values[j] + 0))), Math.floor((values[i] + 0) / -(values[j] + 0)));
+ assertEquals(Math.floor(div(-(values[i] + 0), -(values[j] + 0))), Math.floor(-(values[i] + 0) / -(values[j] + 0)));
+ }
+ }
+}
+
+test_div();
+%OptimizeFunctionOnNextCall(test_div);
+test_div();
« src/ia32/lithium-ia32.h ('K') | « src/x64/lithium-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698