Add symbolic link support to FileSystemFileUtil::AbstractFileEnumerator.

Add symbolic link support to FileSystemFileUtil::AbstractFileEnumerator.


BUG=114732
TEST="existing tests"


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125949

[tzik, 2012-03-08 18:53:01]

As a part of webkit/fileapi/ refactoring, I'd like to access IsLink through
FileEnumerator.
Can I change it like this?

willchan: base/
kinuko: webkit/fileapi/

[kinuko, 2012-03-08 19:12:19]

On 2012/03/08 18:53:01, tzik wrote:
> As a part of webkit/fileapi/ refactoring, I'd like to access IsLink through
> FileEnumerator.
> Can I change it like this?
> 
> willchan: base/
> kinuko: webkit/fileapi/

webkit/fileapi lgtm

This can be implemented w/o the change in base/, but it might be useful to add
that for others.  (Up to base/ OWNERS)

[kinuko, 2012-03-08 19:22:33]

(+mark for base/file_util changes)

On 2012/03/08 19:12:19, kinuko wrote:
> On 2012/03/08 18:53:01, tzik wrote:
> > As a part of webkit/fileapi/ refactoring, I'd like to access IsLink through
> > FileEnumerator.
> > Can I change it like this?
> > 
> > willchan: base/
> > kinuko: webkit/fileapi/
> 
> webkit/fileapi lgtm
> 
> This can be implemented w/o the change in base/, but it might be useful to add
> that for others.  (Up to base/ OWNERS)

[kinuko, 2012-03-09 00:25:53]

Hi Mark,

We'd like to add *IsLink*(const FindInfo& file_info) static method to
FileEnumerator (like IsDirectory) so that the caller can easily check if
the next item is symlink or not.

This simply returns false in Windows case while returns S_ISLINK() result
in POSIX case.  Does this make sense to you?  If so could you take a look
at the change?  (Taiju can add a unit test if adding the method makes sense
to you.)

Thanks,

On Thu, Mar 8, 2012 at 11:22 AM, <kinuko@chromium.org> wrote:

> (+mark for base/file_util changes)
>
>
> On 2012/03/08 19:12:19, kinuko wrote:
>
>> On 2012/03/08 18:53:01, tzik wrote:
>> > As a part of webkit/fileapi/ refactoring, I'd like to access IsLink
>> through
>> > FileEnumerator.
>> > Can I change it like this?
>> >
>> > willchan: base/
>> > kinuko: webkit/fileapi/
>>
>
>  webkit/fileapi lgtm
>>
>
>  This can be implemented w/o the change in base/, but it might be useful
>> to add
>> that for others.  (Up to base/ OWNERS)
>>
>
>
>
>
http://codereview.chromium.**org/9638002/<http://codereview.chromium.org/9638...
>

[Mark Mentovai, 2012-03-09 17:40:37]

LGTM in base.

[commit-bot: I haz the power, 2012-03-09 21:17:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/9638002/1

[commit-bot: I haz the power, 2012-03-10 00:18:33]

Change committed as 125949